Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying license properties #1586

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Clarifying license properties #1586

merged 3 commits into from
Sep 8, 2021

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Sep 8, 2021

See #1563.

principles/fp-001-open.md Outdated Show resolved Hide resolved
Copy link
Contributor

@nataled nataled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new text incorrectly indicates the name of the license, which is Creative Commons Attribution 3.0 Unported. The International version did not start until 4.0. The following is the text after correcting that and other issues as well:

OBO Foundry Ontologies MUST EITHER be released under a Creative Commons Attribution 3.0 Unported (CC BY 3.0) license or later, OR released into the public domain under Creative Commons CC0 1.0 Public Domain Dedication (CC0 1.0). The license MUST be clearly stated using the http://purl.org/dc/terms/license property followed by the URL representing the license (e.g. https://creativecommons.org/licenses/by/3.0/) in the ontology file (OWL example).

Please revise accordingly.

@cthoyt
Copy link
Collaborator

cthoyt commented Sep 8, 2021

if that's the case, then the text should also include the full title of CC BY 4.0 so users know there's a difference in addition to the other 2 examples

@nataled
Copy link
Contributor

nataled commented Sep 8, 2021

CC BY 4.0 isn't mentioned, nor does it need to be since it isn't a requirement. That being said, I think CC BY 4.0 is a better choice of license. The Ops Committee would need to approve this change (it was decided some years ago to keep it at 3.0, but that was when 4.0 was pretty new). For such a discussion, I think it would be useful to count how many still use 3.0. If none, then the change is easy. If there are any that still use it, we could request that they update, and if all do so, the change again is easy.

@matentzn
Copy link
Contributor Author

matentzn commented Sep 8, 2021

Is 4.0 more permissive such that a migration from 3.0 to 4.0 is actually possible?

@matentzn
Copy link
Contributor Author

matentzn commented Sep 8, 2021

@nataled thanks a lot for your review; I have changed the text as per your suggestion, and also added explicitly the CC-BY 4 license an example in brackets (which is safe I would think). We can discuss recommending it officially, but currently, more than half (77) of the active ontologies use CC-BY 3.0.

@matentzn matentzn requested a review from nataled September 8, 2021 16:57
@nataled
Copy link
Contributor

nataled commented Sep 8, 2021

Yes, but that's not the point. Remember, no changes to the meaning of principles occur without Ops discussion. The decision from previous discussion was to use CC BY 3.0 even though CC BY 4.0 was available at the time, so that's what we say in the principle. If we don't have any ontologies using 3.0 than I don't imagine there'd be any issue making the change, but that needs verification.

@matentzn
Copy link
Contributor Author

matentzn commented Sep 8, 2021

Can you double check what comment you commented on, I think we got our comments crossed :D Sorry.

@nataled nataled merged commit c0d426d into master Sep 8, 2021
@nataled nataled deleted the matentzn-patch-12 branch September 8, 2021 17:03
@nataled
Copy link
Contributor

nataled commented Sep 8, 2021

My comment was on the permissiveness question, which I hadn't yet uploaded before you commented again.

@matentzn
Copy link
Contributor Author

matentzn commented Sep 8, 2021

Thank you!

Copy link
Contributor

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes appear to be correct and an improvement--thank you!

I might note that for consistency (and technical correctness) that line 23's "CC-BY" should probably be "CC BY".

@kltm
Copy link
Contributor

kltm commented Sep 8, 2021

NM--merged earlier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants