Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2023-16-15-second-issue-newsletter.md #2448

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Update 2023-16-15-second-issue-newsletter.md #2448

merged 3 commits into from
Sep 19, 2023

Conversation

matentzn
Copy link
Contributor

Update title of newsletter

nataled
nataled reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@nataled nataled left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think the title should be changed (should provide the edition), I don't understand the reasoning behind the proposed changed. Too specific for the contents.

Going forward, we should adopt a naming scheme that doesn't require unique titles. My suggestion is something like "OBO Foundry Newsletter issue 2" (best) or "OBO Foundry Newsletter, Autumn 2023 issue" (okay, but will be problematic if we change frequency or timing).

@anitacaron
Copy link
Contributor

I just checked the newsletter page, and it's not rendering the table in the Spotlight on Software Tools section

Screenshot 2023-09-19 at 15 11 06

@matentzn
Copy link
Contributor Author

@nataled I updated the title to what you suggest, agreed.
@anitacaron I updated the table a bit, hopefully it will work now.

@matentzn
Copy link
Contributor Author

@anitacaron can you approve?

@nataled
Copy link
Contributor

nataled commented Sep 19, 2023

I already did. It can be merged.

@matentzn matentzn merged commit fbc5f03 into master Sep 19, 2023
5 checks passed
@matentzn matentzn deleted the matentzn-patch-13 branch September 19, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataled nataled nataled approved these changes

@anitacaron anitacaron anitacaron approved these changes

@nlharris nlharris Awaiting requested review from nlharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matentzn @anitacaron @nataled