Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mp.mp #2531

Merged
merged 2 commits into from
Mar 3, 2024
Merged

update mp.mp #2531

merged 2 commits into from
Mar 3, 2024

Conversation

sbello
Copy link
Contributor

@sbello sbello commented Feb 29, 2024

added depicted_by line pointing to new MP logo

added depicted by line pointing to new MP logo
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully our template scales the logo appropriately :)

@sbello
Copy link
Contributor Author

sbello commented Feb 29, 2024

That was my concern as well. If it doesn't I can request a smaller scale version. I just need to know the dimensions.

@matentzn matentzn merged commit cd6fc14 into OBOFoundry:master Mar 3, 2024
3 checks passed
@sbello
Copy link
Contributor Author

sbello commented Mar 4, 2024

Instead of showing the logo I just see the word logo on the MP page (http://obofoundry.org/ontology/mp.html), so something is not working. Do I need to use a smaller version of the file? @matentzn Do you know what the dimensions of the image should be?

@deepakunni3
Copy link
Member

Ah, it looks like the URL used is pointing to the GitHub page with the PNG file instead of pointing to the actual PNG.

When referring to content like images, OWL files, zip, etc. you should make use of the raw GitHub URL.

https://github.com/mgijax/mammalian-phenotype-ontology/blob/main/logo/2024_MP_logo_RGB_ICON_color.png points to the page where the logo PNG file is located.

Whereas https://raw.githubusercontent.com/mgijax/mammalian-phenotype-ontology/main/logo/2024_MP_logo_RGB_ICON_color.png points to the actual PNG

@sbello I made a small PR here to fix this issue: #2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants