Add Inactive NOR section to SOP #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlharris
approved these changes
May 14, 2024
| @@ -62,6 +62,13 @@ Part of the NOR review process includes helping submitters navigate through sugg | |||
|
|
|||
| In summary, the designated NOR Reviewer is considered the final arbiter of requirements, and in some cases might have to clarify which suggestions made by other reviewers are required (MUST), which are simply good to do but not required (SHOULD), and which should not be done (MUST NOT). | |||
|
|
|||
| #### Inactive New Ontology Requests | |||
|
|
|||
| In case an open New Ontology Request has not been responded to by the NOR submit for more than 2 months, it is considered inactive. In this case the NOR reviewer should add the following message: | |||
There was a problem hiding this comment.
Suggested change
| In case an open New Ontology Request has not been responded to by the NOR submit for more than 2 months, it is considered inactive. In this case the NOR reviewer should add the following message: | |
| If an open New Ontology Request has not been responded to by the NOR submitter for more than 2 months, it is considered inactive. In this case the NOR reviewer should add the following message: |
|
In general I too approve of the addition. However, there are a number of changes I'd like to make, including to other parts of the SOP. Rather than try to navigate additions upon additions, I'm merging and will submit a separate PR. |
|
One issue of concern is that the criteria for this 'inactive' status is precisely the same as 'rejected', but it was put in a different section of the SOP so that similarity wasn't readily visible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.