Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RoleNORManager.md #2631

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Update RoleNORManager.md #2631

merged 5 commits into from
Aug 20, 2024

Conversation

matentzn
Copy link
Contributor

Replaces #2571

Copy link
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor edits

docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
@matentzn matentzn marked this pull request as ready for review August 11, 2024 21:19
@matentzn matentzn requested a review from nlharris August 11, 2024 21:20
Copy link
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. I found another sentence that was confusing and suggested edits.

docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
@matentzn matentzn requested a review from nlharris August 12, 2024 09:31
@pfabry
Copy link
Contributor

pfabry commented Aug 12, 2024

What was the problem with the previous PR ? Since it seemed to be on my side, I'd like to avoid repeating it.
EDIT: OK, I've seen the problem. How can I avoid that all the document seems changed if I make an edit?

@matentzn
Copy link
Contributor Author

What was the problem with the previous PR ? Since it seemed to be on my side, I'd like to avoid repeating it.

I am not sure, but it looked to me like you were using a windows computer to save the documentation, causing all lines to appear in the diff. Check the diff (files changed) in you PR to see how much red and green there is!

@pfabry
Copy link
Contributor

pfabry commented Aug 12, 2024

I am not sure, but it looked to me like you were using a windows computer to save the documentation, causing all lines to appear in the diff. Check the diff (files changed) in you PR to see how much red and green there is!

Indeed, I am using a Windows computer. If I am converting the EOL character to Unix format, that should do the trick?

@matentzn
Copy link
Contributor Author

I would hope so, but I can't promise it :)

docs/roles/RoleNORManager.md Outdated Show resolved Hide resolved
@matentzn matentzn requested a review from nlharris August 19, 2024 05:41
@nataled
Copy link
Contributor

nataled commented Aug 19, 2024

FWIW, I agree with Nomi's proposed change.

@pfabry
Copy link
Contributor

pfabry commented Aug 19, 2024

FWIW, I agree with Nomi's proposed change.

Me too.

@nlharris
Copy link
Contributor

I assume I'm not supposed to re-review this?

@matentzn matentzn requested review from pfabry and nataled August 20, 2024 05:45
@matentzn
Copy link
Contributor Author

For QC purposes you have to approve!

@nlharris nlharris merged commit 67a1a85 into master Aug 20, 2024
5 checks passed
@anitacaron anitacaron deleted the matentzn-patch-18 branch November 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants