-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RoleNORManager.md #2631
Update RoleNORManager.md #2631
Conversation
Replaces #2571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting minor edits
Co-authored-by: Nomi Harris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine. I found another sentence that was confusing and suggested edits.
Co-authored-by: Nomi Harris <[email protected]>
What was the problem with the previous PR ? Since it seemed to be on my side, I'd like to avoid repeating it. |
I am not sure, but it looked to me like you were using a windows computer to save the documentation, causing all lines to appear in the diff. Check the diff (files changed) in you PR to see how much red and green there is! |
Indeed, I am using a Windows computer. If I am converting the EOL character to Unix format, that should do the trick? |
I would hope so, but I can't promise it :) |
Co-authored-by: Nomi Harris <[email protected]>
FWIW, I agree with Nomi's proposed change. |
Me too. |
I assume I'm not supposed to re-review this? |
For QC purposes you have to approve! |
Replaces #2571