Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported freezegun to 13.0 requirements.txt from 14.0 #1236

Closed

Conversation

Ana-Iarajuli
Copy link

@Ana-Iarajuli Ana-Iarajuli commented Jun 18, 2024

Description of the issue/feature this PR addresses:
freezegun not added to the 13.0 oca-ci container, which caused failed checks on my PR during migrating one of the modules: https://github.com/OCA/stock-logistics-warehouse/pull/2056

Current behavior before PR:
getting failed checks

Desired behavior after PR is merged:
checks are successful


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza
Copy link
Member

This should be done adding the library in the file test-requirements.txt of the repository, not here.

@pedrobaeza pedrobaeza closed this Jun 18, 2024
@Ana-Iarajuli
Copy link
Author

Ana-Iarajuli commented Jun 19, 2024

This should be done adding the library in the file test-requirements.txt of the repository, not here.

I added it to the test_requirements.txt on OCA/stock_logistics_warehouse but my checks still failed due to the same module. Do I need to improve something in my code?
https://github.com/OCA/stock-logistics-warehouse/pull/2056

@pedrobaeza
Copy link
Member

The file name should be test-requirements.txt (with dash, not underscore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants