[16.0] [MIG] account_fiscal_year_closing #248

Borruso · 2023-06-14T15:17:11Z

Migration account_fiscal_year_closing from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

miguel-binaural · 2023-06-27T14:28:46Z

Will this be merged?

SirAionTech

Thanks for the PR!
Please squash the commits as described in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate.

SirAionTech · 2023-10-03T07:51:16Z

account_fiscal_year_closing/models/account_fiscalyear_closing_abstract.py

-    account_type_id = fields.Many2one(
-        comodel_name="account.account.type",
-        string="Account type",
+    account_type = fields.Selection(


This change requires a migration, otherwise when a database is migrated the existing records will have an empty account_type instead of having the value corresponding to their old account_type_id.
You can have a look at https://oca.github.io/OpenUpgrade for better understanding what a migration is.

Since the migration is usually not trivial and it does not really affect the module's behavior, sometimes this can be done later; this will be probably decided by whoever wants to merge this module.

If this is the case, please at least write a note in the roadmap of the module.

create migration
await you feedback

SirAionTech · 2023-10-03T07:57:21Z

account_fiscal_year_closing/tests/test_account_fiscal_year_closing.py

+                    not in [
+                        "asset_receivable",  # Receivable
+                        "asset_current",  # Current Assets
+                        "income",  # Current Assets


Suggested change

"income", # Current Assets

"income", # Income

SirAionTech

Commit 21851e9 is missing from history

SirAionTech · 2023-10-06T10:59:07Z

account_fiscal_year_closing/models/account_fiscalyear_closing_abstract.py

-    account_type_id = fields.Many2one(
-        comodel_name="account.account.type",
-        string="Account type",
+    account_type = fields.Selection(


SirAionTech · 2023-10-06T10:59:52Z

account_fiscal_year_closing/tests/test_account_fiscal_year_closing.py

+                    not in [
+                        "asset_receivable",  # Receivable
+                        "asset_current",  # Current Assets
+                        "income",  # Current Assets


Borruso · 2023-10-06T11:16:06Z

Commit 21851e9 is missing from history

done

gjlong68 · 2023-10-18T01:02:36Z

V16

Borruso · 2023-10-20T08:31:17Z

V16

@gjlong68, can you check again, please?

GSLabIt

multi company fix

GSLabIt · 2023-10-25T15:12:26Z

account_fiscal_year_closing/security/account_fiscalyear_closing_security.xml

+        <field name="global" eval="True" />
+        <field
+            name="domain_force"
+        >['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>


Suggested change

>['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>

>['|', ('company_id', '=', False), ('company_id', 'in', company_ids)]</field>

GSLabIt · 2023-10-25T15:12:43Z

account_fiscal_year_closing/security/account_fiscalyear_closing_security.xml

+        <field name="global" eval="True" />
+        <field
+            name="domain_force"
+        >['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>


Suggested change

>['|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>

>['|', ('company_id', '=', False), ('company_id', 'in', company_ids)]</field>

Borruso · 2023-10-26T08:06:41Z

multi company fix

@GSLabIt thanks for suggest
added migration

gjlong68 · 2023-10-29T12:30:37Z

Borruso:OK

mde-scopea · 2024-01-15T08:59:32Z

Hi guys, thanks for your job.

Has anyone tested the migration script?

On my side, it's KO (I'm on Odoo.sh), the pre-mig script doesn't work.
IDs, use with env.ref("account.data_account_type*), don't exist on the migrated system (when the pre script runs)

SirAionTech · 2024-01-15T09:16:18Z

Has anyone tested the migration script?

I didn't

On my side, it's KO (I'm on Odoo.sh), the pre-mig script doesn't work.
IDs, use with env.ref("account.data_account_type*), don't exist on the migrated system (when the pre script runs)

Then please add that as a review to the PR, have a look at https://odoo-community.org/resources/review if you don't know how.

pedrobaeza · 2024-03-14T19:47:15Z

Please include 55998e8 in this PR.

pedrobaeza · 2024-03-14T19:47:25Z

/ocabot migration account_fiscal_year_closing

lk-eska · 2024-05-10T08:10:52Z

These 2 PR's are will be necessary as well:

#288
#294

When creating from scratch, Mapping is used as an Array instead of simple id (due to many in another many). When coming from a template, id is used To take into account this particularity, check the type before taking the id of the array.

OKT96 · 2024-08-02T09:55:59Z

account_fiscal_year_closing/migrations/16.0.1.0.0/pre-migration.py

+            UPDATE {table} aa
+            SET account_type = atm.account_type
+            FROM account_type_map atm
+            WHERE atm.user_type_id = aa.user_type_id


ERROR: column aa.user_type_id does not exist LINE 35: WHERE atm.user_type_id = aa.user_type_id ^ HINT: Perhaps you meant to reference the column "atm.user_type_id".

user_type_id does not exist in any of the two tables? (account_fiscalyear_closing_type_template, account_fiscalyear_closing_type)

yes field user_type_id become account_type

odoo/odoo@26b2472 user_type_id -> account_type ~~account.account.type~~

SirAionTech

I proposed Borruso#1 to support the flow where accounting data is created without loading a template chart of accounts

peterromao · 2024-09-25T14:21:29Z

Hello guys,

Where can I translate this module for version 16? It's not on Weblate. Also as I see it it is not yet merged into the 16.0 branch either right?

andreampiovesana · 2024-11-07T14:55:15Z

can you enable runboat?
is good for functional review and/or merge?

Although we originally developped the module, we figured out soon that this approach is not correct, so we prefer to not appearing in the credits.

Borruso · 2024-11-08T10:02:50Z

Please include 55998e8 in this PR.

commit included

MaurizioPellegrinet

Functional test: OK

OCA-git-bot · 2024-11-10T16:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AinohaBH

Functional: LGTM

andreampiovesana

LGTM, MERGE?

salvorapi

LGTM

Borruso · 2025-01-23T14:22:23Z

@pedrobaeza merge?

PS
After merge I will create PR for v17 and v18

pedrobaeza · 2025-01-23T14:25:14Z

Well, I discourage the use of this module, and I don't think it's really needed in Italy, but merging due to reviews.

/ocabot merge nobump

OCA-git-bot · 2025-01-23T14:25:22Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-248-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-01-23T14:35:29Z

Congratulations, your PR was merged at 3c54a8d. Thanks a lot for contributing to OCA. ❤️

lk-eska · 2025-01-23T16:39:45Z

Well, I discourage the use of this module, and I don't think it's really needed in Italy, but merging due to reviews.

/ocabot merge nobump

then how do we achieve the closing process? would you point us to a direction? thanks.
@pedrobaeza

pedrobaeza · 2025-01-23T16:44:55Z

Legislations usually don't talk about any "closing process". They just ask for financial books. The closing process is an old artificial method for being able to obtain that books with the limited resources that exist some time ago. A lot of people say the same that "systems have to make the closing", but we are working since a lot in Odoo without it, and other systems like SAP or Navision do the same.

lk-eska · 2025-01-23T18:09:07Z

I believe people insist using this module because this is a legal requirement in their country (we are also in this boat).

pedrobaeza · 2025-01-23T18:41:42Z

That's what I think that it's not really required in your country...

Borruso mentioned this pull request Jun 14, 2023

Migration to version 16.0 #203

Open

7 tasks

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from b05e291 to 4917d69 Compare July 21, 2023 12:42

SirAionTech suggested changes Oct 3, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from 4917d69 to a36c164 Compare October 6, 2023 10:35

Borruso requested a review from SirAionTech October 6, 2023 10:37

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch 3 times, most recently from 8a0946f to 92f8abb Compare October 6, 2023 11:07

SirAionTech suggested changes Oct 6, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from 92f8abb to 18480fd Compare October 6, 2023 11:15

Borruso requested a review from SirAionTech October 6, 2023 11:16

SirAionTech approved these changes Oct 6, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch 2 times, most recently from 596da34 to 3142b69 Compare October 19, 2023 14:00

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from 3142b69 to 6d874db Compare October 20, 2023 08:33

GSLabIt reviewed Oct 25, 2023

View reviewed changes

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from 6d874db to 646f046 Compare October 26, 2023 08:04

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from 646f046 to 92367bb Compare November 13, 2023 08:19

mde-scopea mentioned this pull request Mar 14, 2024

[14.0] [FIX] account_fiscal_year_closing - create/write #294

Closed

[FIX] account_fiscal_year_closing: create/write

0e5cd59

When creating from scratch, Mapping is used as an Array instead of simple id (due to many in another many). When coming from a template, id is used To take into account this particularity, check the type before taking the id of the array.

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from b54b04a to 0e5cd59 Compare August 1, 2024 10:19

OKT96 reviewed Aug 2, 2024

View reviewed changes

SirAionTech reviewed Aug 26, 2024

View reviewed changes

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from a3c19a5 to cc851f5 Compare November 8, 2024 09:59

[REF] account_fiscal_year_closing: Debrand module

ff71bb5

Although we originally developped the module, we figured out soon that this approach is not correct, so we prefer to not appearing in the credits.

Borruso force-pushed the 16.0-mig-account_fiscal_year_closing branch from cc851f5 to ff71bb5 Compare November 8, 2024 10:00

MaurizioPellegrinet approved these changes Nov 10, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 10, 2024

AinohaBH approved these changes Nov 26, 2024

View reviewed changes

andreampiovesana approved these changes Nov 27, 2024

View reviewed changes

almumu approved these changes Jan 2, 2025

View reviewed changes

salvorapi approved these changes Jan 7, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 23, 2025

OCA-git-bot merged commit decb974 into OCA:16.0 Jan 23, 2025
8 of 9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 23, 2025

	>['\|', ('company_id', '=', False), ('company_id', 'child_of', [user.company_id.id])]</field>
	>['\|', ('company_id', '=', False), ('company_id', 'in', company_ids)]</field>

[16.0] [MIG] account_fiscal_year_closing #248

[16.0] [MIG] account_fiscal_year_closing #248

Conversation

Borruso commented Jun 14, 2023 • edited Loading

miguel-binaural commented Jun 27, 2023 • edited Loading

SirAionTech left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Borruso Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Borruso Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SirAionTech left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Borruso commented Oct 6, 2023

gjlong68 commented Oct 18, 2023

Borruso commented Oct 20, 2023

GSLabIt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Borruso commented Oct 26, 2023

gjlong68 commented Oct 29, 2023

mde-scopea commented Jan 15, 2024

SirAionTech commented Jan 15, 2024

pedrobaeza commented Mar 14, 2024

pedrobaeza commented Mar 14, 2024

lk-eska commented May 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SirAionTech left a comment

Choose a reason for hiding this comment

peterromao commented Sep 25, 2024

andreampiovesana commented Nov 7, 2024 • edited Loading

Borruso commented Nov 8, 2024 • edited Loading

MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 10, 2024

AinohaBH left a comment

Choose a reason for hiding this comment

andreampiovesana left a comment

Choose a reason for hiding this comment

salvorapi left a comment

Choose a reason for hiding this comment

Borruso commented Jan 23, 2025 • edited Loading

pedrobaeza commented Jan 23, 2025

OCA-git-bot commented Jan 23, 2025

OCA-git-bot commented Jan 23, 2025

lk-eska commented Jan 23, 2025 • edited Loading

pedrobaeza commented Jan 23, 2025

lk-eska commented Jan 23, 2025

pedrobaeza commented Jan 23, 2025

Borruso commented Jun 14, 2023 •

edited

Loading

miguel-binaural commented Jun 27, 2023 •

edited

Loading

Borruso Oct 6, 2023 •

edited

Loading

Borruso Oct 6, 2023 •

edited

Loading

SirAionTech left a comment •

edited

Loading

andreampiovesana commented Nov 7, 2024 •

edited

Loading

Borruso commented Nov 8, 2024 •

edited

Loading

Borruso commented Jan 23, 2025 •

edited

Loading

lk-eska commented Jan 23, 2025 •

edited

Loading