Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] account_cutoff_base: auto reverse #270

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[16.0][IMP] account_cutoff_base: auto reverse #270

merged 1 commit into from
Oct 10, 2024

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Oct 25, 2023 •
edited
Loading

Allow to automatically reverse generated moves

Added test move creation

cc @alexis-via @rousseldenis

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@jbaudoux jbaudoux marked this pull request as ready for review October 26, 2023 16:24
rousseldenis
rousseldenis approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@jbaudoux jbaudoux changed the title [IMP] account_cutoff_base: auto reverse [16.0][IMP] account_cutoff_base: auto reverse Nov 17, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024
@jbaudoux
Copy link
Contributor Author

@OCA/accounting-maintainers Can this one be merged ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
@jbaudoux
Copy link
Contributor Author

@OCA/accounting-maintainers Could you merge this PR please ?

@grindtildeath
Copy link
Contributor

@jbaudoux it's missing an approval but I'll remove the stale label

@grindtildeath grindtildeath added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jul 29, 2024
sbidoul
sbidoul reviewed Jul 31, 2024
View reviewed changes
account_cutoff_base/models/account_cutoff.py
string="Cut-off Journal Entry Reversal",
readonly=True,
copy=False,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be late to the party, but could we make this a computed field based on env["account.move"].search[("reversed_entry_id", "=", self.move_id)].

Copy link
Member

@sbidoul sbidoul Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or self.move_id.reversal_move_id and self.move_id.reversal_move_id[0]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds better indeed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to use a compute. Can you re-review? Thanks

@jbaudoux jbaudoux force-pushed the 16.0-auto_reverse branch 4 times, most recently from 73fcaf3 to d19e4c5 Compare August 8, 2024 11:13
@jbaudoux
[IMP] account_cutoff_base: auto reverse
ffdb023 
Allow to automatically reverse generated moves
@jbaudoux jbaudoux force-pushed the 16.0-auto_reverse branch from d19e4c5 to ffdb023 Compare August 8, 2024 11:16
@jbaudoux
Copy link
Contributor Author

@sbidoul Can we merge this now?

@lmignon
Copy link

lmignon commented Oct 10, 2024

@sbidoul Can we move forward with this? It works in production for a long time now.

@sbidoul
Copy link
Member

sbidoul commented Oct 10, 2024

Yes, I had lost track of this.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-270-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 16e762d into OCA:16.0 Oct 10, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8544536. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbaudoux @OCA-git-bot @grindtildeath @lmignon @sbidoul @rousseldenis