Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][PORT] account_invoice_start_end_dates: add start/end dates in tree view of move lines #303

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[17.0][PORT] account_invoice_start_end_dates: add start/end dates in tree view of move lines #303

merged 1 commit into from
Dec 3, 2024

Conversation

henrybackman
Copy link

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

sebalix
sebalix reviewed Sep 12, 2024
View reviewed changes
account_invoice_start_end_dates/views/account_move_line.xml Outdated
<field name="must_have_dates" invisible="1" />
<field
name="start_date"
attrs="{'required': [('must_have_dates', '=', True)]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
attrs="{'required': [('must_have_dates', '=', True)]}"
required="must_have_dates"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

account_invoice_start_end_dates/views/account_move_line.xml Outdated
/>
<field
name="end_date"
attrs="{'required': [('must_have_dates', '=', True)]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
attrs="{'required': [('must_have_dates', '=', True)]}"
required="must_have_dates"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alexis-via @henrybackman
account_invoice_start_end_dates: add start/end dates in tree view of …
5879beb 
…move lines

The 2 new fields are hidden by default
@henrybackman henrybackman force-pushed the oca-port-from-14.0-to-17.0-pr-195 branch from 60a27ab to 5879beb Compare September 12, 2024 09:12
@sebalix
Copy link
Contributor

sebalix commented Sep 12, 2024 •
edited
Loading

In fact the change was already there but done through another commit. The only relevant change brought here is the split of XML views in two files: account_move.xml and account_move_line.xml, reducing the gap of commits between 14.0 and 17.0.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@henrybackman
Copy link
Author

@sebalix The runboat/build check seems stuck. Is there a way to restart that?

@alexis-via
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-303-by-alexis-via-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fc7c6cb into OCA:17.0 Dec 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a8f92f3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@gbrito gbrito gbrito approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@henrybackman @OCA-git-bot @sebalix @alexis-via @gbrito