[16.0][FIX] account_financial_report: Remove inactive analytic account relations

[sergiobstoj]

When an analytic account is set to inactive (active=False), the relation with Journal Item is not automatically removed. This causes inactive analytic accounts to still appear linked to journal items when grouping by Analytic Account.

• Current behavior before PR

  • When using the edition mode in tree view from Journal Items, when removing an Analytic Account, the field analytic_account_ids is updated.
  • Here is the behavior with active analytic accounts.
    test_with_active_account.webm
  • Inactive analytic accounts are not being unlinked from account.move.line records.
    test_with_inactive_account.webm

• Behavior with PR

  • With this PR, the relation is properly removed and Journal Item is not linked to inactive account
    test_with_pr.webm

Changes

• Remove self.analytic_account_ids = False
• Replace with: self.with_context(active_test=False).analytic_account_ids = [(6, 0, [])] to consider archived analytic account.

[pedrobaeza]

The current behavior is correct, as you have to see the historical data of that account, no matter if currently the analytic account is archived. It's the same as if you archive a partner.

[sergiobstoj]

Hi @pedrobaeza

But if we attempt to remove from a Journal Item the archived Analytic Account, shouldn't it be unlinked?

That's the only case being considered here. If we don't remove an archived Analytic Account, the relation still remains.

two-archived-accounts.webm

[pedrobaeza]

Why don't you put ondelete="cascade" instead?

[sergiobstoj]

ondelete="cascade" does not accomplish the desired behaviour

[pedrobaeza]

Yeah, but I'm afraid this is not valid either. As said, an archived analytic account must still be shown in financial reports.

[luc-demeyer]

I agree with Pedro on this topic.