[16.0][FIX] account_chart_update: Translatable fields without transla… #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions may raise errors as its fetched by the wizard but has no translated value @moduon MT-8280
|
Hi @rafaelbn, |
yajo
reviewed
Dec 30, 2024
| stored_translation_rec = field._get_stored_translations(rec) | ||
| if not stored_translation_rec: | ||
| continue | ||
| old_value = stored_translation_rec.get(rec.env.lang, "en_US") |
There was a problem hiding this comment.
Didn't you mean this?
Suggested change
| old_value = stored_translation_rec.get(rec.env.lang, "en_US") | |
| old_value = stored_translation_rec.get(rec.env.lang or "en_US") or "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions may raise errors as its fetched by the wizard but has no translated value
This fix has been made in cases where there are differences in the translation but there is no prior definition in the field (e.g. the field was originally empty).
@moduon MT-8280
@EmilioPascual @yajo @rafaelbn please review, if you can.