[MIG] account_invoice_refund_link: Migration to 17.0

OCA · Apr 21, 2024 · f2c12d9 · f2c12d9
1 parent 8af8727
commit f2c12d9
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 22 deletions.
diff --git a/account_invoice_refund_link/__manifest__.py b/account_invoice_refund_link/__manifest__.py
@@ -6,7 +6,7 @@
 
 {
     "name": "Show links between refunds and their originator invoices.",
-    "version": "16.0.1.0.4",
+    "version": "17.0.1.0.0",
     "development_status": "Mature",
     "category": "Accounting & Finance",
     "website": "https://github.com/OCA/account-invoicing",

diff --git a/account_invoice_refund_link/hooks.py b/account_invoice_refund_link/hooks.py
@@ -2,8 +2,6 @@
 # Copyright 2017-2018 Tecnativa - Pedro M. Baeza
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import SUPERUSER_ID, api
-
 
 def match_origin_lines(refund):
     """Try to match lines by product or by description."""
@@ -24,8 +22,7 @@ def match_origin_lines(refund):
             break
 
 
-def post_init_hook(cr, registry):
-    env = api.Environment(cr, SUPERUSER_ID, {})
+def post_init_hook(env):
     # Linking all refund invoices to its original invoices
     refunds = env["account.move"].search(
         [

diff --git a/account_invoice_refund_link/tests/test_invoice_refund_link.py b/account_invoice_refund_link/tests/test_invoice_refund_link.py
@@ -8,7 +8,7 @@
 
 
 class TestInvoiceRefundLinkBase(TransactionCase):
-    refund_method = "refund"
+    is_modify = False
 
     @classmethod
     def setUpClass(cls):
@@ -84,11 +84,10 @@ def setUpClass(cls):
             active_ids=cls.invoice.ids, active_model="account.move"
         ).create(
             {
-                "refund_method": cls.refund_method,
                 "reason": cls.refund_reason,
                 "journal_id": cls.journal.id,
             }
-        ).reverse_moves()
+        ).reverse_moves(is_modify=cls.is_modify)
 
     def _test_refund_link(self):
         self.assertTrue(self.invoice.refund_invoice_ids)
@@ -118,7 +117,7 @@ def test_post_init_hook(self):
         refund = self.invoice.refund_invoice_ids[0]
         refund.invoice_line_ids.write({"origin_line_id": False})
         self.assertFalse(refund.mapped("invoice_line_ids.origin_line_id"))
-        post_init_hook(self.env.cr, None)
+        post_init_hook(self.env)
         self.refund_reason = "The refund reason"
         self._test_refund_link()
 
@@ -140,15 +139,15 @@ def test_refund_copy(self):
         )
 
 
-class TestInvoiceRefundCancelLink(TestInvoiceRefundLinkBase):
-    refund_method = "cancel"
+class TestInvoiceRefundNoModifyLink(TestInvoiceRefundLinkBase):
+    is_modify = False
 
     def test_refund_link(self):
         self._test_refund_link()
 
 
 class TestInvoiceRefundModifyLink(TestInvoiceRefundLinkBase):
-    refund_method = "modify"
+    is_modify = True
 
     def test_refund_link(self):
         self._test_refund_link()
diff --git a/account_invoice_refund_link/views/account_invoice_view.xml b/account_invoice_refund_link/views/account_invoice_view.xml
@@ -18,15 +18,15 @@
                 <page
                     name="refunds"
                     string="Refunds"
-                    attrs="{'invisible':[('move_type', 'not in', ['in_invoice', 'out_invoice'])]}"
+                    invisible="move_type not in ('in_invoice', 'out_invoice')"
                 >
                     <field name="refund_invoice_ids" nolabel="1">
                         <tree
                             decoration-info="state == 'draft'"
                             decoration-muted="state == 'cancel'"
                         >
-                            <field name="partner_id" invisible="1" />
-                            <field name="move_type" invisible="1" />
+                            <field name="partner_id" column_invisible="1" />
+                            <field name="move_type" column_invisible="1" />
                             <field name="invoice_date" />
                             <field name="name" />
                             <field name="invoice_origin" />
@@ -68,11 +68,7 @@
                     name="reversed_entry_id"
                     string="Invoice reference"
                     readonly="1"
-                    attrs="{'invisible': [
-                    '|',
-                    ('reversed_entry_id', '=', False),
-                    ('move_type', 'not in', ('in_refund', 'out_refund'))
-                ]}"
+                    invisible="not reversed_entry_id or move_type not in ('in_refund', 'out_refund')"
                 />
             </field>
         </field>

diff --git a/account_invoice_refund_link/wizards/account_move_reversal.py b/account_invoice_refund_link/wizards/account_move_reversal.py
@@ -7,11 +7,11 @@
 class AccountMoveReversal(models.TransientModel):
     _inherit = "account.move.reversal"
 
-    def reverse_moves(self):
+    def reverse_moves(self, is_modify=False):
         """
         Only link invoice lines with theirs original lines when the reversal
         move has been done from reversal wizard.
         """
         return super(
             AccountMoveReversal, self.with_context(link_origin_line=True)
-        ).reverse_moves()
+        ).reverse_moves(is_modify=is_modify)