[ADD] [15.0]account_invoice_date #1166

ikapasi-initos · 2022-05-26T10:56:48Z

No description provided.

dsolanki-initos

Code review and functional test.
LGTM!

AaronHForgeFlow · 2022-06-01T13:36:13Z

Commit history is missing. Can you follow the steps described here https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 ?

antoniocanovas · 2022-06-02T08:37:14Z

Is it a migration or a new one?
I can't find it in previous versions...

AaronHForgeFlow · 2022-06-02T09:19:58Z

If this is a new module, can you please remove the word "migration" from the title here as well? thanks :)

rafaelbn · 2022-06-02T20:12:32Z

Hello @ikapasi-initos , I'm curious about why you this this module. Is this a UX button?

#. Go to Invoice > Click Create > Create new invoice.
#. Click on "Confirm" button.
#. Select the date and Click on "Open invoice" button.

jans23 · 2022-06-15T09:27:22Z

Yes, it's a button which allows to choose the invoice date when confirming the invoice. This helps when the company uses "actual taxation" (instead of "imputed taxation") which is not supported by Odoo directly.

ikapasi-initos · 2022-07-08T08:42:26Z

Hello @dalonsod it would be great if you add reviews here.

dalonsod

Thanks for the contribution!
Tested in runboat, AFAIK works. Code review, in general OCA conventions for new addons should be followed and pre-commit run -a command seems to be missing, see comments.

dalonsod · 2022-07-13T13:38:12Z

account_invoice_date/README.rst

@@ -0,0 +1,6 @@
+====================


This file should not be included, it'll be autogenerated later

Hi, @dalonsod when I remove the " README.rst" file and then I've run the "pre-commit run -a" command faced an issue in the " README.rst" file. Please find the attached image.

dalonsod · 2022-07-13T13:38:42Z

account_invoice_date/i18n/de.po

@@ -0,0 +1,106 @@
+# Translation of Odoo Server.


Please remove this, translations should be added using Weblate

dalonsod · 2022-07-13T13:39:30Z

account_invoice_date/models/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-


These headers are actually unncessary in python files

dalonsod · 2022-07-13T13:40:07Z

account_invoice_date/security/ir.model.access.csv

+
+

Remove extra blank lines.

removed extra lines

dalonsod · 2022-07-13T13:40:38Z

account_invoice_date/views/account_move_view.xml

+            </button>
+        </field>
+    </record>
+</odoo>


Missing empty line at file end

An added empty line.

dalonsod · 2022-07-13T13:41:28Z

account_invoice_date/wizard/account_voucher_proforma_date.py

+import logging
+
+from odoo import api, fields, models
+
+_logger = logging.getLogger(__name__)


Unused import and variable, and api not used

Removed unnecessary imports

dalonsod · 2022-07-13T13:42:01Z

account_invoice_date/wizard/account_voucher_proforma_date.py

+    _description = "Account Voucher Proforma Date"
+
+    date = fields.Date(
+        string="Rechnungsdatum", required=True, default=fields.Date.context_today


string attribute in english

Added the English string.

dalonsod · 2022-07-13T13:46:55Z

account_invoice_date/__manifest__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+{
+    "name": "Account Invoice Date",
+    "description": """


Use summary instead of description

Replaced description with a summary.

dalonsod · 2022-07-13T13:49:10Z

account_invoice_date/__manifest__.py

+    """,
+    "category": "Accounting",
+    "version": "15.0.1.0.0",
+    "license": "LGPL-3",


License not coherent with file header

BTW, we don't have a strong preference. Does OCA prefer any particular license or use by default?

@jans23 Both are accepted and it is the author choice. Tipically it is AGPL unless it is a base module that is meant to be used in many other places. I think this module will not be used as dependency for others so APGL is fine.

ikapasi-initos · 2022-07-15T10:06:05Z

Hi,@dalonsod I've implemented the feedback you can review it.

ikapasi-initos · 2022-07-22T10:01:07Z

Hi, @BT-anieto it would be great if you add reviews here

AaronHForgeFlow · 2022-07-23T12:55:01Z

account_invoice_date/README.rst

+====================
+
+When an invoice is validated from Draft to Open automatically, the invoice date
+is set to current date.If an invoice is validated from Draft to Open manually, a window is displayed to query the invoice date from the user.


Suggested change

is set to current date.If an invoice is validated from Draft to Open manually, a window is displayed to query the invoice date from the user.

is set to current date. If an invoice is validated from Draft to Open manually, a window is displayed to query the invoice date from the user.

Can you put this in the first comment of the PR? this is a new module. People should know what is this about without looking at the code. Thanks.

AaronHForgeFlow

Functional review works fine

AaronHForgeFlow · 2022-07-27T09:39:24Z

account_invoice_date/wizard/account_voucher_proforma_date_view.xml

+                <group>
+                    <field
+                        name="date"
+                        string="Please enter invoice date (should correspond to payment date)"


Suggested change

string="Please enter invoice date (should correspond to payment date)"

string="Please enter invoice date"

I would avoid the part between brackets, but it is not blocking.

Hi, @AaronHForgeFlow I've implemented the changes.

AaronHForgeFlow

if the invoice date is already set, I would not show the wizard, just post the invoice as usual:

jans23 · 2022-07-29T10:50:38Z

if the invoice date is already set, I would not show the wizard, just post the invoice as usual:

Good idea. That should also work for our workflow.

ikapasi-initos · 2022-08-30T05:42:52Z

@AaronHForgeFlow Could you please review it?

dsolanki-initos · 2022-12-08T09:22:08Z

Hi, @max3903 Could you please review this PR?

dsolanki-initos · 2023-02-21T09:34:12Z

Could you add at least one unit test that checks the main flow is correct? Thank you!

Sure, I'll add the test case

dsolanki-initos · 2023-02-21T12:41:00Z

Could you add at least one unit test that checks the main flow is correct? Thank you!

@AaronHForgeFlow, I've added the test cases kindly review them. Thank you

AaronHForgeFlow

Functional review

dsolanki-initos · 2023-02-27T12:56:07Z

Hello @dalonsod, In this PR all the changes as per your feedback have been done, Kindly review it.

dalonsod · 2023-02-28T18:36:07Z

I still see de.po file. Remove it and I'll approve it. Thanks for your patience!

jans23 · 2023-02-28T19:04:55Z

I don't understand. Why should the German translation be removed? Is there an alternative to the de.po file to provide translation?

dalonsod · 2023-03-01T07:16:26Z

Well, for new modules adding po files is actually allowed (https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#translations). Alternative, as usual, is Weblate once addon is merged.

OCA-git-bot · 2023-03-01T09:14:46Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

account_invoice_date/readme/USAGE.rst

AaronHForgeFlow · 2023-03-01T12:19:24Z

LGTM

jans23 · 2023-03-24T10:10:29Z

@AaronHForgeFlow This PR is approved and read-to-merge. What can we do to get it merged?

rafaelbn

When an customer invoice or vendor bill is validated from Draft to Open automatically, the invoice/bill date is set to current date. If an invoice/bill is validated from Draft to Open manually, a window is displayed to query the invoice/bill date from the user.

The name of the module IMHO is incorrecto as indicate that you are adding fields date in invoices

@AaronHForgeFlow could you say a better name like account_invoice_date_update or something similar?

Thank you all! 😄

jans23 · 2023-03-31T18:44:14Z

We will happily change the module's name to whatever name you agree on.

github-actions · 2024-02-25T12:13:03Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

* Modified account_invoice_date/models/account_move.py so that a name is always set * Changed the way name is set in order to work with tranlations

github-actions · 2024-09-08T12:16:59Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

dsolanki-initos approved these changes Jun 1, 2022

View reviewed changes

ikapasi-initos changed the title ~~[MIG] account_invoice_date: Migration to 15.0~~ [ADD] account_invoice_date: Migration to 15.0 Jun 2, 2022

ikapasi-initos changed the title ~~[ADD] account_invoice_date: Migration to 15.0~~ [ADD] [15.0]account_invoice_date Jun 3, 2022

ikapasi-initos force-pushed the 15.0-mig-account_invoice_date branch from 49dfc0d to d2ace09 Compare June 3, 2022 12:27

dalonsod suggested changes Jul 13, 2022

View reviewed changes

dalonsod reviewed Jul 13, 2022

View reviewed changes

ikapasi-initos force-pushed the 15.0-mig-account_invoice_date branch from d2ace09 to 0ded821 Compare July 14, 2022 05:33

AaronHForgeFlow reviewed Jul 23, 2022

View reviewed changes

ikapasi-initos force-pushed the 15.0-mig-account_invoice_date branch from 0ded821 to 1306823 Compare July 25, 2022 06:20

AaronHForgeFlow reviewed Jul 27, 2022

View reviewed changes

ikapasi-initos force-pushed the 15.0-mig-account_invoice_date branch 4 times, most recently from 8c77dae to 42292df Compare July 29, 2022 10:10

AaronHForgeFlow requested changes Jul 29, 2022

View reviewed changes

ikapasi-initos force-pushed the 15.0-mig-account_invoice_date branch from 42292df to e08ad33 Compare August 8, 2022 09:25

ikapasi-initos requested review from AaronHForgeFlow and dalonsod August 10, 2022 10:21

dsolanki-initos force-pushed the 15.0-mig-account_invoice_date branch from 7bf57ea to 0f2295b Compare January 18, 2023 09:06

dsolanki-initos force-pushed the 15.0-mig-account_invoice_date branch from 402da0b to 9d7a5c8 Compare February 21, 2023 12:33

AaronHForgeFlow approved these changes Feb 21, 2023

View reviewed changes

dsolanki-initos force-pushed the 15.0-mig-account_invoice_date branch from 9d7a5c8 to 263794c Compare February 27, 2023 10:46

dalonsod approved these changes Mar 1, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 1, 2023

AaronHForgeFlow reviewed Mar 1, 2023

View reviewed changes

account_invoice_date/readme/USAGE.rst Outdated Show resolved Hide resolved

dsolanki-initos force-pushed the 15.0-mig-account_invoice_date branch from 263794c to 6fa1ec5 Compare March 1, 2023 09:53

rafaelbn reviewed Mar 31, 2023

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024

ozoromo force-pushed the 15.0-mig-account_invoice_date branch 2 times, most recently from f4235e0 to 6fa1ec5 Compare March 18, 2024 19:52

[ADD] account_invoice_date

044d38e

ozoromo force-pushed the 15.0-mig-account_invoice_date branch from 6fa1ec5 to 044d38e Compare March 18, 2024 20:11

Modified account_invoice_date/models/account_move.py (#2)

06dec85

* Modified account_invoice_date/models/account_move.py so that a name is always set * Changed the way name is set in order to work with tranlations

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024

github-actions bot closed this Oct 13, 2024

	is set to current date.If an invoice is validated from Draft to Open manually, a window is displayed to query the invoice date from the user.
	is set to current date. If an invoice is validated from Draft to Open manually, a window is displayed to query the invoice date from the user.

	string="Please enter invoice date (should correspond to payment date)"
	string="Please enter invoice date"

[ADD] [15.0]account_invoice_date #1166

[ADD] [15.0]account_invoice_date #1166

Conversation

ikapasi-initos commented May 26, 2022

dsolanki-initos left a comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Jun 1, 2022

antoniocanovas commented Jun 2, 2022

AaronHForgeFlow commented Jun 2, 2022

rafaelbn commented Jun 2, 2022

jans23 commented Jun 15, 2022

ikapasi-initos commented Jul 8, 2022 • edited Loading

dalonsod left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikapasi-initos commented Jul 15, 2022

ikapasi-initos commented Jul 22, 2022

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

jans23 commented Jul 29, 2022

ikapasi-initos commented Aug 30, 2022

dsolanki-initos commented Dec 8, 2022

dsolanki-initos commented Feb 21, 2023

dsolanki-initos commented Feb 21, 2023

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

dsolanki-initos commented Feb 27, 2023

dalonsod commented Feb 28, 2023

jans23 commented Feb 28, 2023

dalonsod commented Mar 1, 2023

OCA-git-bot commented Mar 1, 2023

AaronHForgeFlow commented Mar 1, 2023

jans23 commented Mar 24, 2023

rafaelbn left a comment

Choose a reason for hiding this comment

jans23 commented Mar 31, 2023

github-actions bot commented Feb 25, 2024

github-actions bot commented Sep 8, 2024

ikapasi-initos commented Jul 8, 2022 •

edited

Loading