Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_fiscal_position_update #1263

Conversation

ljsalvatierra-factorlibre

alexis-via and others added 30 commits October 11, 2022 15:23
Currently translated at 100,0% (4 of 4 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/nl_NL/
Currently translated at 100,0% (4 of 4 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/pt_BR/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/nl/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/es/
… taxes when this was changed.

Otherwise the taxes are not changed when change the fpos.
Don't create new variant, just use the default one.
@oca-clabot
Copy link

Hey @ljsalvatierra-factorlibre, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre changed the title 16.0 mig account invoice fiscal position update [16.0][MIG] account_invoice_fiscal_position_update Oct 13, 2022
@rafaelbn
Copy link
Member

/ocabot migration account_invoice_fiscal_position_update

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 18, 2022
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review Ok.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1263-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bb27a70 into OCA:16.0 Nov 2, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bd1c52e. Thanks a lot for contributing to OCA. ❤️

@loida-vm
Copy link

loida-vm commented Nov 3, 2022

Functional review LGTM

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre deleted the 16.0-mig-account_invoice_fiscal_position_update branch January 26, 2023 14:35
odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
Signed-off-by rafaelbn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.