Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_invoice_crm_tag: Migration to 17.0 #1622

Merged
merged 9 commits into from
Apr 4, 2024
Merged

[17.0][MIG] account_invoice_crm_tag: Migration to 17.0 #1622

merged 9 commits into from
Apr 4, 2024

Conversation

peluko00
Copy link

No description provided.

stefan-tecnativa and others added 7 commits November 29, 2023 13:00
@stefan-tecnativa @pedrobaeza @peluko00
[ADD] account_invoice_crm_tag: CRM tags on invoices
c25154a 
TT44457

Co-Authored-By: Pedro M. Baeza <[email protected]>
@OCA-git-bot @peluko00
[ADD] icon.png
d73a494
@pedrobaeza @peluko00
[FIX] account_invoice_crm_tag: Proper field name SO > invoice
1b19aba 
It was renamed to `crm_tag_ids` during the development phase, but this
was not changed.

TT44592
@pedrobaeza @peluko00
[FIX+IMP] account_invoice_crm_tag: Proper line tag propagation + colors
40707ee 
- Transfer properly CRM tags also to invoice lines, as although being a
  related stored, it's not correctly saved due to the trick/duality of
  invoice_line_ids/line_ids.
- Put color definition in many2many_tags widget.

TT44457
@Ivorra78 @peluko00
Translated using Weblate (Spanish)
79380c3 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-15.0/account-invoicing-15.0-account_invoice_crm_tag
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-15-0/account-invoicing-15-0-account_invoice_crm_tag/es/
@ernesto-garcia-tecnativa @peluko00
[MIG] account_invoice_crm_tag: Migration to 16.0
95018d4
@peluko00
[UPD] Update account_invoice_crm_tag.pot
ab6efae
@pedrobaeza
Copy link
Member

Missing "pre-commit" commit.

/ocabot migration account_invoice_crm_tag

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 29, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 29, 2023
Open
46 tasks
@peluko00 peluko00 force-pushed the 17.0-mig-account_invoice_crm_tag branch from fd00203 to c7590b5 Compare November 29, 2023 12:09
@peluko00
Copy link
Author

peluko00 commented Nov 29, 2023 •
edited
Loading

Module migrated to version 17.0

cc https://github.com/APSL 148963

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue https://github.com/OCA/hr/issues/1600

David-solyddigital
David-solyddigital approved these changes Nov 29, 2023
View reviewed changes
Copy link

@David-solyddigital David-solyddigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional is OK

moitabenfdz
moitabenfdz approved these changes Jan 8, 2024
View reviewed changes
Copy link

@moitabenfdz moitabenfdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review. LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 12, 2024 •
edited
Loading

Please fix commit history (missing pre-commit commit, weird [UPD] Update account_invoice_crm_tag.pot commit, etc) and you will need to rebase this branch and fix the things that arise.

@peluko00 peluko00 force-pushed the 17.0-mig-account_invoice_crm_tag branch from 8d78c7e to 1461174 Compare April 4, 2024 14:52
@peluko00
Copy link
Author

peluko00 commented Apr 4, 2024

Please @pedrobaeza can you review it

pedrobaeza
pedrobaeza approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot migration account_invoice_crm_tag
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1622-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4df8595 into OCA:17.0 Apr 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 51c194e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-solyddigital David-solyddigital David-solyddigital approved these changes

@moitabenfdz moitabenfdz moitabenfdz approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@peluko00 @pedrobaeza @OCA-git-bot @moitabenfdz @David-solyddigital @stefan-tecnativa @Ivorra78 @ernesto-garcia-tecnativa