Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] account_move_tier_validation: Pass context to allow confirming moves with tier validation #1703

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[16.0][FIX] account_move_tier_validation: Pass context to allow confirming moves with tier validation #1703

merged 1 commit into from
Sep 6, 2024

Conversation

ByteMeAsap
Copy link

Fixes #1698

patrickrwilson pushed a commit to ursais/osi-addons that referenced this pull request May 20, 2024
[FIX] account_tier_validation (Confirm Issue)
0fa6a02 
Applies: OCA/account-invoicing#1703
This was referenced May 20, 2024
Merged
Closed
StefanRijnhart
StefanRijnhart requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It's not entirely clear to me what causes the issue. Would it be possible to add a reproducing test?

@ByteMeAsap
Copy link
Author

Thanks for the fix. It's not entirely clear to me what causes the issue. Would it be possible to add a reproducing test?

@StefanRijnhart , if you check the issue #1698 , it details the steps that causes the issue. Is it possible for you to review it?

@StefanRijnhart
Copy link
Member

@ByteMeAsap If it's that easy, then it should definitely be included as a test in the module.

@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_move_tier_validation branch 2 times, most recently from f156be2 to 7c7ca0c Compare August 22, 2024 09:33
@ByteMeAsap
[FIX] account_move_tier_validation: Pass context to allow confirming …
cf44d37 
…moves with tier validation

Added tests for changes

Updated error to be checked in tests

Updated error to be checked in tests
@ByteMeAsap ByteMeAsap force-pushed the 16.0-fix-account_move_tier_validation branch from 7c7ca0c to cf44d37 Compare August 22, 2024 09:50
@ByteMeAsap
Copy link
Author

@ByteMeAsap If it's that easy, then it should definitely be included as a test in the module.

@StefanRijnhart , I have added the test scripts

StefanRijnhart
StefanRijnhart approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for adding the test!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ByteMeAsap
Copy link
Author

Can we have this merged?

@StefanRijnhart
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1703-by-StefanRijnhart-bump-patch, awaiting test results.

@StefanRijnhart StefanRijnhart changed the title [FIX] account_move_tier_validation: Pass context to allow confirming moves with tier validation [16.0][FIX] account_move_tier_validation: Pass context to allow confirming moves with tier validation Sep 6, 2024
@StefanRijnhart StefanRijnhart added this to the 16.0 milestone Sep 6, 2024
@OCA-git-bot OCA-git-bot merged commit 8d3b3b1 into OCA:16.0 Sep 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bea359d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ByteMeAsap @StefanRijnhart @OCA-git-bot @gurneyalex