Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_invoice_fixed_discount: avoid replace in xml #1710

Merged

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Apr 22, 2024

forward port of #1593

Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@CRogos
Copy link
Contributor Author

CRogos commented Apr 24, 2024

@JordiBForgeFlow you've merged it into 16.0 . Could you review and merge?

@CRogos
Copy link
Contributor Author

CRogos commented May 15, 2024

@pedrobaeza could you merge this forward port?

@pedrobaeza pedrobaeza added this to the 17.0 milestone May 15, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1710-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4fca7c7 into OCA:17.0 May 15, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d0c554. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-imp-account_invoice_fixed_discount-port branch May 16, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants