Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][mig]stock_account_move_reset_to_draft #1854

Open
wants to merge 5 commits into
base: 17.0
Choose a base branch
from

Conversation

leemannd
Copy link

@leemannd leemannd commented Nov 26, 2024

Standard migration of the module to 17.0

@leemannd leemannd marked this pull request as draft November 26, 2024 09:57
@leemannd leemannd changed the title [17.0][mig stock_account_move_reset_to_draft] [17.0][mig]stock_account_move_reset_to_draft Nov 26, 2024
@leemannd leemannd force-pushed the 17.0-mig-stock_account_move_reset_to_draft branch from 921bb40 to 29d3d73 Compare November 26, 2024 09:58
@leemannd leemannd force-pushed the 17.0-mig-stock_account_move_reset_to_draft branch 4 times, most recently from cadb60a to 6e1e2f2 Compare November 26, 2024 13:15
@leemannd leemannd marked this pull request as ready for review November 26, 2024 13:19
@@ -4,7 +4,7 @@
"name": "Stock account move reset to draft",
"author": "Tecnativa, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/account-invoicing",
"version": "16.0.1.0.1",
"version": "17.0.1.0.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some maintainers want to maintain the 3 last version numbers inbetween odoo versions.
I can update it to 17.0.1.0.0 if required

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were supposed to make it 17.0.1.0.0. What is the rationale of keeping the last three digits?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some maintainers keep the 3 digits up to date inbetween versions. The rationale behind this is to be able to know which fixes/features are included.
The usual procedure is to set as you say 17.0.1.0.0.

Beside that @yostashiro , if you have the time for a review, you're welcome.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the rule, and it shouldn't be, as it's very easy to desynchronize such versions and a maintenance burden to synchronize them with no added benefit. Anyway, the only I know doing it is mis_builder, which is more a Python engine than Odoo code, and then it's more possible (although I also don't like it).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza Agreed. I have updated the version number. If you have time to drop a review, you're welcome.

@leemannd leemannd force-pushed the 17.0-mig-stock_account_move_reset_to_draft branch from 6e1e2f2 to 6414f82 Compare November 28, 2024 07:41
@pedrobaeza
Copy link
Member

/ocabot migration stock_account_move_reset_to_draft

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 28, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 28, 2024
46 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK looking at the diff review, but @yostashiro should confirm all the valuation stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants