-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][mig]stock_account_move_reset_to_draft #1854
base: 17.0
Are you sure you want to change the base?
[17.0][mig]stock_account_move_reset_to_draft #1854
Conversation
Corrected inaccurate information in the README.
921bb40
to
29d3d73
Compare
cadb60a
to
6e1e2f2
Compare
@@ -4,7 +4,7 @@ | |||
"name": "Stock account move reset to draft", | |||
"author": "Tecnativa, Odoo Community Association (OCA)", | |||
"website": "https://github.com/OCA/account-invoicing", | |||
"version": "16.0.1.0.1", | |||
"version": "17.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some maintainers want to maintain the 3 last version numbers inbetween odoo versions.
I can update it to 17.0.1.0.0
if required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were supposed to make it 17.0.1.0.0
. What is the rationale of keeping the last three digits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some maintainers keep the 3 digits up to date inbetween versions. The rationale behind this is to be able to know which fixes/features are included.
The usual procedure is to set as you say 17.0.1.0.0
.
Beside that @yostashiro , if you have the time for a review, you're welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not the rule, and it shouldn't be, as it's very easy to desynchronize such versions and a maintenance burden to synchronize them with no added benefit. Anyway, the only I know doing it is mis_builder
, which is more a Python engine than Odoo code, and then it's more possible (although I also don't like it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza Agreed. I have updated the version number. If you have time to drop a review, you're welcome.
6e1e2f2
to
6414f82
Compare
/ocabot migration stock_account_move_reset_to_draft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems OK looking at the diff review, but @yostashiro should confirm all the valuation stuff.
Standard migration of the module to 17.0