Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig account cash discount write off #606

Closed
wants to merge 58 commits into from

Conversation

AnizR
Copy link

@AnizR AnizR commented Mar 8, 2023

Depends on #588

This migration is done considering that we use odoo/account instead of oca/account_cash_discount_base to manage discounts.

benwillig and others added 27 commits February 14, 2023 12:21
[ADD] Allow to configure discount options directly on the payment term

[ADD] Add account cash discount payment module

[MIG] account_cash_discount_payment migration. Also removed force_discount_amount from the account.invoice

[ADD] Allow to tell if a payment line is paid using the discount or not. Keep the original amount in order to compute it again
…ked to an invoice which has a discount

[CHG] Use a computed flag to know if there is tax adjustments or not

[CHG] When the pay_with_discount flag is changed, the amount to paid is computed based on the invoice total and the invoice total with the discount amount deducted

[FIX] Invoice report should display the amount_total_with_discount instead of the discount_amount

[CHG] Use a single date as a search filter for the discount due date

[FIX] The generated discount write off move should be posted depending on the payment mode configuration

[CHG] only the pay_with_discount flag should decide if the write off should be created or not

[CHG] The accounting partner is already the one defined on the move line
…e tax lines

[CHG] changed the way to populate tax's move lines debit/credit fields

[FIX] the discount due date should be recomputed when the invoice data changes

[FIX] the amount of the payment line should not include the discount if the current date is posterior to the discount due date

[IMP] Display a button on the payment line tree view to toggle the pay with discount flag

[ADD] Show the discount amount/due date in the payment line generation wizard

[FIX] Keep the base line with taxes

[FIX] do not allow to change the pay_with_discount field value if the payment order is done

[CHG] display a filled/emtpy checkbox depending if the discount has been enabled or not

[FIX] use the writeoff account for a non tax line

[ADD] display the discount due date/amount in the move line search more

[FIX] the domain should be recomputed when the discount due date changes

[FIX] new onchange method to disable the discount if the amount of a payment line has been changed manually. The writeoff shouldn't be created if the amount of the line doesn't correspond to the invoice total with discount

[FIX] the pay with discount field should not be visible if the invoice has already been paid partially

[FIX] discount data should only be visible in a supplier invoice
…tains a discount

[ADD] use the supplier payment term when creating a refund
[ADD] allow to toggle the discount on the payment order even if the discount due date is in the past

[FIX] force to load discount payment term options when the partner changes
@AnizR AnizR force-pushed the 16.0-mig-account_cash_discount_write_off branch from e084a91 to 903d2bf Compare March 8, 2023 13:25
@AnizR AnizR force-pushed the 16.0-mig-account_cash_discount_write_off branch 2 times, most recently from f3532b9 to 9b16304 Compare March 29, 2023 10:20
@AnizR AnizR force-pushed the 16.0-mig-account_cash_discount_write_off branch from 9b16304 to 319d77a Compare June 19, 2023 09:41
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023
@AnizR AnizR force-pushed the 16.0-mig-account_cash_discount_write_off branch 3 times, most recently from a24545c to 9983159 Compare December 1, 2023 09:39
@AnizR AnizR force-pushed the 16.0-mig-account_cash_discount_write_off branch from 9983159 to 23ee663 Compare December 1, 2023 09:45
@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants