Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] account_move_line_payment: simple partial overdue payment flow #709

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[ADD] account_move_line_payment: simple partial overdue payment flow #709

wants to merge 1 commit into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Feb 12, 2024

New module that simplifies the use case of registering partial invoice payments.

@moduon MT-5071

Gelojr
Gelojr approved these changes Feb 13, 2024
View reviewed changes
Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Very nice job @yajo
https://www.loom.com/share/7a9a98ccbbfd4f5a8b4de43265eaef33?sid=55eb7e93-e26e-4a44-81f4-0d0b3fc0bb12

https://www.loom.com/share/5269c180efb949a8a29f9dd12fafc141?sid=9dc00eda-9539-4808-abbe-7e1df694fa22

rafaelbn
rafaelbn reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @yajo review what is already done in 17 to make migration direct

Also the module name in my head is more like account_move_line_payment

fcvalgar
fcvalgar approved these changes Feb 13, 2024
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.
LGTM.

Thak you @yajo

@yajo yajo marked this pull request as draft February 14, 2024 07:43
@yajo yajo changed the title [ADD] account_payment_overdue: simple partial overdue payment flow [ADD] account_move_line_payment: simple partial overdue payment flow Feb 14, 2024
@yajo yajo marked this pull request as ready for review February 14, 2024 10:16
@yajo
Copy link
Member Author

yajo commented Feb 14, 2024

New changes:

  • Module renamed.
  • Added to roadmap that this doesn't need fwports.

@yajo yajo requested a review from rafaelbn February 14, 2024 10:16
rafaelbn
rafaelbn approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! 👍🏼

As said, this is already in Odoo 17, so this module will not be migrated!

Thank you! ❤️

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yajo
[ADD] account_move_line_payment: simple partial overdue payment flow
7946a48 
New module that simplifies the use case of registering partial invoice payments.

@moduon MT-5071
@rafaelbn
Copy link
Member

Hello @OCA/banking-maintainers ,

This a backport of a Odoo 17 new menu and functionality and it doesn't need yo be migrated.

Please could you take a look?

Thanks
Regards,
Rafael

rafaelbn
rafaelbn approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @rafaelbn you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@yajo
Copy link
Member Author

yajo commented Jun 26, 2024

Hello @etobella @HaraldPanten @JordiBForgeFlow. This is a practical module that has been working in production for 4 months already. Could somebody hit the merge button? 😇 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

@Gelojr Gelojr Gelojr approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yajo @OCA-git-bot @rafaelbn @fcvalgar @Gelojr