[15.0][IMP] account_check_report many fixes and improvements #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yment only not other payments [IMP] account_check_report: show amount residual at the payment date, not on todays date [IMP] account_check_report: show direct refund applied on invoices paid by the check e.g. 2 invoices and a refund for those 2 invoices should appear, even if the refund includes separate invoices [IMP]account_check_report: button invoices show all related invoices + direct refunds [IMP] account_check_report: add test coverage [IMP] account_check_report: do not print more than one line by invoice. Currently, if there are several receivable/payable lines, for example, due to payment terms the invoice appears multiple times
AaronHForgeFlow
force-pushed
the
15.0-fix-account_check_report
branch
from
fa744cf
to
def7142
Compare
AaronHForgeFlow
force-pushed
the
15.0-fix-account_check_report
branch
from
def7142
to
7bf6bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] account_check_report: payment amount should consider current payment and not other payments
[IMP] account_check_report: show amount residual at the payment date, not on today's date
[IMP] account_check_report: show direct refund applied on invoices paid by the check e.g. 2 invoices and a refund for those 2 invoices should appear, even if the refund includes separate invoices
[IMP]account_check_report: button invoices show all related invoices + direct refunds
[IMP] account_check_report: add test coverage
[IMP] account_check_report: do not print more than one line by invoice. Currently, if there are several receivable/payable lines, for example, due to payment terms the invoice appears multiple times
Kind of forward porting this #397
The changes in the payment document itself can be reverted if only the report is accepted.