Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] account_payment_term_extension: Add selection options translatable #734

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from

Conversation

ramiadavid
Copy link

No description provided.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Jun 5, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the occasion to rename the method to the guideline _selection_delay_type.

@ramiadavid ramiadavid force-pushed the 17.0-fix-account_payment_term_extension branch from 3a4b85d to b4cde30 Compare June 5, 2024 10:26
@ramiadavid
Copy link
Author

@pedrobaeza Why don't all the terms to translate appear on weblate? In the .pot file they do appear, but in the .po of the languages, there are many that do not appear, and I don't know how to add them, since it says that it is 100% translated when it is not.
image
image

@pedrobaeza
Copy link
Member

Can you mention one specifically? The bot, after a merge, regenerate the POT file, and then reapply the POT on each .po, so they should be synchronized. Maybe something in the middle has failed.

@ramiadavid
Copy link
Author

In the images you can see that in English there are 46 terms vs 33 in Spanish
For example "Days and Months" in spanish in Spanish it is not

@pedrobaeza
Copy link
Member

@sbidoul do you know why there's no PO update after POT regeneration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants