Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] account payment term partner holiday #744

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0] [MIG] account payment term partner holiday #744

wants to merge 1 commit into from

Conversation

PabloCatalinaCastello
Copy link

@PabloCatalinaCastello PabloCatalinaCastello commented Jul 2, 2024 •
edited
Loading

@PabloCatalinaCastello PabloCatalinaCastello changed the title 16.0 mig account payment term partner holiday [16.0] [MIG] account payment term partner holiday Jul 4, 2024
@PabloCatalinaCastello PabloCatalinaCastello force-pushed the 16.0-mig-account_payment_term_partner_holiday branch 4 times, most recently from 8fbceee to a9f86cb Compare July 10, 2024 06:44
alvaro-domatix
alvaro-domatix suggested changes Jul 12, 2024
View reviewed changes
account_payment_term_partner_holiday/models/account_move.py Outdated
"""Inject a context for getting the partner when computing payment term."""
for move in self:
super(
AccountMove, self.with_context(move_partner_id=move.partner_id.id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If self is being iterated the super should be done for "move.with_context(..." not "self.with_context(..."

@PabloCatalinaCastello PabloCatalinaCastello force-pushed the 16.0-mig-account_payment_term_partner_holiday branch from dcb282e to 423671b Compare July 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaro-domatix alvaro-domatix alvaro-domatix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PabloCatalinaCastello @alvaro-domatix