Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_payment_widget_amount: Migration to 17.0 #745

Open
wants to merge 28 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] account_payment_widget_amount: Migration to 17.0 #745

wants to merge 28 commits into from

Conversation

dc-oerp
Copy link

@dc-oerp dc-oerp commented Jul 3, 2024

Migrate account_payment_widget_amount module from 16.0 to 17.0

AdriaGForgeFlow and others added 27 commits July 3, 2024 11:26
@AdriaGForgeFlow @dc-oerp
[10.0][ADD] account_payment_widget_amount module
6ffe67b
@AdriaGForgeFlow @dc-oerp
[12.0][MIG] account_payment_widget_amount module
0a91a49
@AdriaGForgeFlow @dc-oerp
[IMP] replace popover depending on screen size
d234369
@JordiBForgeFlow @dc-oerp
- adds fixes to the logic to reconcile the amount maid
5d713af 
- adds tests to the python side
@oca-travis @dc-oerp
[UPD] Update account_payment_widget_amount.pot
fd8c0a2
@OCA-git-bot @dc-oerp
[UPD] README.rst
49bebbf
@pedrocs-exo @dc-oerp
Added translation using Weblate (Portuguese)
da912f6
@pedrocs-exo @dc-oerp
Translated using Weblate (Portuguese)
d99467e 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-payment-12.0/account-payment-12.0-account_payment_widget_amount
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_payment_widget_amount/pt/
@marcelsavegnago @dc-oerp
Added translation using Weblate (Portuguese (Brazil))
e725e4a
@ChrisOForgeFlow @dc-oerp
[IMP] account_payment_widget_amount: black, isort, prettier
5c3e5ec
@ChrisOForgeFlow @dc-oerp
[14.0][MIG] account_payment_widget_amount
fbe64f1
@ChrisOForgeFlow @dc-oerp
[IMP] added as mainteiner
3422c67
@oca-travis @dc-oerp
[UPD] Update account_payment_widget_amount.pot
03867ef
@OCA-git-bot @dc-oerp
[UPD] README.rst
e38ad5c
@ChrisOForgeFlow @dc-oerp
[15.0][MIG] account_payment_widget_amount
9a0b977
@dc-oerp
[UPD] Update account_payment_widget_amount.pot
df143c2
@OCA-git-bot @dc-oerp
[UPD] README.rst
e28687e
@jabelchi @dc-oerp
Added translation using Weblate (Catalan)
b8aa98b
@jabelchi @dc-oerp
Translated using Weblate (Catalan)
7c4e0da 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-payment-15.0/account-payment-15.0-account_payment_widget_amount
Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_widget_amount/ca/
@douglascstd @dc-oerp
Translated using Weblate (Portuguese (Brazil))
9eddaa6 
Currently translated at 100.0% (4 of 4 strings)

Translation: account-payment-15.0/account-payment-15.0-account_payment_widget_amount
Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_widget_amount/pt_BR/
@dsolanki-initos @dc-oerp
[IMP] account_payment_widget_amount: pre-commit stuff
895773e
@dsolanki-initos @dc-oerp
[MIG] account_payment_widget_amount: Migration to 16.0
ea68035
@dc-oerp
[UPD] Update account_payment_widget_amount.pot
f704a87
@OCA-git-bot @dc-oerp
[BOT] post-merge updates
38c44bf
@mymage @dc-oerp
Added translation using Weblate (Italian)
e6a137b
@mymage @dc-oerp
Translated using Weblate (Italian)
939427c 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-payment-16.0/account-payment-16.0-account_payment_widget_amount
Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_payment_widget_amount/it/
@dc-oerp
[IMP] account_payment_widget_amount: pre-commit auto fixes
3c57814
@dc-oerp dc-oerp force-pushed the 17.0-mig-account_payment_widget_amount branch 3 times, most recently from af28a62 to 963715a Compare July 4, 2024 13:31
@dc-oerp dc-oerp force-pushed the 17.0-mig-account_payment_widget_amount branch 3 times, most recently from 25c4459 to 1c5e7f1 Compare July 4, 2024 17:02
@dc-oerp
Copy link
Author

dc-oerp commented Jul 5, 2024

Can someone please check this pre-commit issue?

@dc-oerp
Copy link
Author

dc-oerp commented Jul 19, 2024

Hi @rousseldenis

Could you please take a look at this as well?
I'm not sure why it's giving an error in the pre-commit.

Thank you

@rousseldenis
Copy link
Sponsor Contributor

@dc-oerp Sorry, I'm not js specialist. Maybe @pedrobaeza

@dc-oerp
Copy link
Author

dc-oerp commented Jul 25, 2024

Hi @ChrisOForgeFlow @pedrobaeza

Could you please check the pre-commit issue in this PR?
Let me know if I need to make any repairs.

Thank you

@pedrobaeza
Copy link
Member

The error seems clear:

 /home/runner/work/account-payment/account-payment/account_payment_widget_amount/static/src/js/account_payment_field.js
  3:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

you need to fix that. If the JS code is modern style, you need to rename the file to .esm.js.

@dc-oerp dc-oerp force-pushed the 17.0-mig-account_payment_widget_amount branch from 8b3f6d0 to 22dc423 Compare July 25, 2024 13:48
@dc-oerp
Copy link
Author

dc-oerp commented Aug 1, 2024

Hi @pedrobaeza

I have fixed the js pre-commit issue and I think this is ready to be merged.

Thank you

@pedrobaeza
Copy link
Member

/ocabot migration account_payment_widget_amount

Well, now it's OK formally. Then there must be reviews:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 1, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 1, 2024
Open
10 tasks
@dc-oerp
Copy link
Author

dc-oerp commented Aug 28, 2024

Hi @pedrobaeza

Should I tag somebody to review this?
What needs to be done for the next step?

Thank you

@pedrobaeza
Copy link
Member

Ping the original contributors of the module, and you can review other PRs and ask in exchange that they review yours.

@dc-oerp
Copy link
Author

dc-oerp commented Sep 3, 2024

Hi @ChrisOForgeFlow

Could you please review this PR?

Thank you

ChrisOForgeFlow
ChrisOForgeFlow approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Functional and code review

@dc-oerp dc-oerp force-pushed the 17.0-mig-account_payment_widget_amount branch from 6fd24c1 to 329804f Compare September 4, 2024 13:24
@dc-oerp dc-oerp force-pushed the 17.0-mig-account_payment_widget_amount branch from 43b8894 to 862f9ba Compare September 4, 2024 13:26
@dc-oerp
Copy link
Author

dc-oerp commented Sep 4, 2024

Hi @rousseldenis

All comments have been fixed.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisOForgeFlow ChrisOForgeFlow ChrisOForgeFlow approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.