Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] account_reconcile_analytic_tag: New module #758

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 26, 2024

New module

ejemplo

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT51885

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. Just a few code remarks

account_reconcile_analytic_tag/__manifest__.py Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 16.0-add-account_reconcile_analytic_tag branch from 8980ab3 to c443b0d Compare November 26, 2024 15:11
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests 👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-758-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e61875 into OCA:16.0 Nov 26, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 54a1511. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-account_reconcile_analytic_tag branch November 26, 2024 16:30
chienandalu pushed a commit to Tecnativa/account-reconcile that referenced this pull request Nov 27, 2024
Useful for extensions like this one OCA#758

TT51885
chienandalu pushed a commit to Tecnativa/account-reconcile that referenced this pull request Nov 27, 2024
Useful for extensions like this one OCA#758

TT51885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants