[14.0][FIX] account_statement_import_txt_xlsx: handle empty debit/credit #546
Conversation
|
Hi @alexey-pelykh, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
I have rebased now. Can we merge? |
github-actions
bot
removed
the
stale
|
This PR has the |
|
Hi @alexey-pelykh |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@pedrobaeza @MiquelRForgeFlow @alexey-pelykh |
| @@ -1,5 +1,5 @@ | |||
| "Date","Label","Debit","Credit","Balance","Partner Name","Bank Account" | |||
| "12/15/2018","Credit 20.00","0.00","20.00","-10.00","John Doe","123456789" | |||
| "12/15/2018","Debit empty, Credit 20",,"20","-10.00","John Doe","123456789" | |||
There was a problem hiding this comment.
| "12/15/2018","Debit empty, Credit 20",,"20","-10.00","John Doe","123456789" | |
| "12/15/2018","Debit empty, Credit 20.00",,"20.00","-10.00","John Doe","123456789" |
🤔
There was a problem hiding this comment.
I set 20 to test that it works with an integer. Should I write Debit empty, Credit integer?
There was a problem hiding this comment.
I have now written Debit test empty, Credit test integer to be clear on why I have empty / integer values.
github-actions
bot
removed
the
stale
|
Can we merge this now? |
|
/ocabot rebase |
|
Congratulations, PR rebased to 14.0. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@alexey-pelykh your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-546-by-alexey-pelykh-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Can anyone explain the failed check? I don't understand what is the problem. |
ghost
closed this by deleting the head repository
When the bank statement import file has two amount columns (in and out), each line is using one column (in or out), and the other column is empty. With this fix, empty values will be handled correctly.