Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journal matching for CAMT files from e.g. Commerzbank #624

Closed
wants to merge 1 commit into from

Conversation

luc-demeyer
Copy link
Contributor

No description provided.

Copy link

@BT-cjimeno BT-cjimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I think it's needed to also check if result["account_number"] and result["currency"] are there before the last character checks.

Or this is what I see them doing at the bottom of this file

Tested successfully with files from Commerzbank that contain the currency at the end of the bank_account, e.g. "EUR" while the matching journals in Odoo don't include the currency code at the end.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 21, 2024
@github-actions github-actions bot closed this Feb 25, 2024
@luc-demeyer
Copy link
Contributor Author

Can this PR be reopened ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants