Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] account_statement_import_online_gocardless: Slash at the end #713

Merged
merged 1 commit into from
Aug 11, 2024
Merged

[16.0][FIX] account_statement_import_online_gocardless: Slash at the end #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions account_statement_import_online_gocardless/models/online_bank_statement_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
self, endpoint, request_type="get", params=None, data=None, basic_auth=False
):
content = {}
url = url_join(GOCARDLESS_API, endpoint)
url = url_join(GOCARDLESS_API, endpoint) + "/"

Check warning on line 64 in account_statement_import_online_gocardless/models/online_bank_statement_provider.py

View check run for this annotation

Codecov / codecov/patch

account_statement_import_online_gocardless/models/online_bank_statement_provider.py#L64 

Added line #L64 was not covered by tests
response = getattr(requests, request_type)(
url,
data=data,
Expand Down Expand Up @@ -143,9 +143,9 @@
"view_mode": "form",
"target": "new",
}
return self._gocardless_select_bank_instituion()
return self._gocardless_select_bank_institution()

Check warning on line 146 in account_statement_import_online_gocardless/models/online_bank_statement_provider.py

View check run for this annotation

Codecov / codecov/patch

account_statement_import_online_gocardless/models/online_bank_statement_provider.py#L146 

Added line #L146 was not covered by tests

def _gocardless_select_bank_instituion(self):
def _gocardless_select_bank_institution(self):
"""Ask for the GoCardless bank instituion and continue full linkage."""
country = (
self.journal_id.bank_account_id.company_id or self.journal_id.company_id
Expand Down
Loading