Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] account_statement_import_move_line: Set reference in bank statment lines #733

Merged

Conversation

pilarvargas-tecnativa
Copy link

The ‘ref’ field is not visible on invoices of type ‘out_invoice’. In the tests, it is adding value to this field and therefore does not fail to create a bank statement line where the ‘payment_ref’ field is required. To solve this, the value of the ‘payment_ref’ field of the bank statement lines is set as the reference of a supplier invoice (‘ref’ in invoice lines) or as the reference of the payment ‘payment_reference’ (‘name’ in invoice lines).

cc @Tecnativa

…ment lines

The ‘ref’ field is not visible on invoices of type ‘out_invoice’.
In the tests, it is adding value to this field and therefore does not
fail to create a bank statement line where the ‘payment_ref’ field is
required. To solve this, the value of the ‘payment_ref’ field of the
bank statement lines is set as the reference of a supplier invoice
(‘ref’ in invoice lines) or as the reference of the payment
‘payment_reference’ (‘name’ in invoice lines).
@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pilarvargas-tecnativa pilarvargas-tecnativa changed the title [FIX] account_statement_import_move_line: Set reference in bank statment lines [15.0][FIX] account_statement_import_move_line: Set reference in bank statment lines Oct 29, 2024
@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 29, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review October 29, 2024 11:26
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can avoid problems this way. Let's fast-track it:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-733-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d62de72 into OCA:15.0 Oct 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8e9b54b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-account_statement_import_move_line branch October 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants