[17.0][MIG] account_statement_import_online_ponto: Migration to 17.0 #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also Rename account_bank_statement_import_online => account_statement_import_online
Not sure why, cert validation was disabled. That is insecure. @Tecnativa TT31034
Currently translated at 43.7% (7 of 16 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online_ponto/it/
Check situation that should raise exception immediately, prevent ident on normal flow
1. Find partner if ther already is a bank account with the right IBAN; 2. Store (and display) raw import data to help in problem determination; 3. Make it easy to extend the parsing of import data; 4. Apply some clean coding principles.
Currently translated at 100.0% (16 of 16 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online_ponto/ca/
The 2 modules account_statement_import_online and account_statement_import depend on account_statement_import_base (and not on each other) and share common code, in particular a hook to update the statement line. So we can now have reconciliation modules that use this hook and therefore work both on file import and online import. More details on OCA#481. Improve bank statement line form view and journal form view.
Separate retrieval of data from ponto (buffer data) and creation of statements.
Add debug messages Set raw_data in bank statement lines
With Ponto we can only retrieve data backwards in time. Therefore we override the normal _pull method to create statements in descending order of statement date.
Currently translated at 100.0% (24 of 24 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_ponto/es/
Currently translated at 91.6% (22 of 24 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_ponto/nl/
…ttempt to modify of posted account.move
Currently translated at 100.0% (16 of 16 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_online_ponto/it/
ChristianTessera
force-pushed
the
17.0-mig-account_statement_import_online_ponto
branch
from
e15637a
to
0c4586c
Compare
victoralmau
approved these changes
Nov 15, 2024
ChristianTessera
changed the title
|
/ocabot migration account_statement_import_online_ponto |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f604acd. Thanks a lot for contributing to OCA. ❤️ |
|
This is the only suggestion after testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to 17.0