Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] brand_external_report_layout : keep original company for report… #180

Closed
wants to merge 2 commits into from

Conversation

metaminux
Copy link

…s and just temporarily use brand data

  • do not use company details and footer from brand, so that it could be used in multi-company
  • this avoid conflicts with other modules overriding company to add information in reports

Fixes #167
Fixes #179

@OCA-git-bot
Copy link
Contributor

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@metaminux
Copy link
Author

Hi @sbejaoui and others,

In this PR, I had to make some arbitrary choices about the list of fields to override...
Maybe we can offer the final user some flexibility using config parameters...

Do not hesitate to review, give advice, discuss.

Regards,

…s and just temporarily use brand data - do not use company details and footer from brand, so that it could be used in multi-company - this avoid conflicts with other modules overriding company to add information in reports Fixes OCA#167 Fixes OCA#179
…s and just temporarily use brand data - do not use company details and footer from brand, so that it could be used in multi-company - this avoid conflicts with other modules overriding company to add information in reports Fixes OCA#167 Fixes OCA#179
@metaminux
Copy link
Author

Hello everyone,

Before spending more time on test coverage, I'd like some thoughts about this implementation.

I think avoiding conflicts with other modules and enabling multi-company is necessary for larger adoption, but I'm not sure about updating company with brand data during report rendering and choices made about fields to really consider...

Anyone ? @sbejaoui ? @pierre-halleux ? @jdoutreloux ?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024
@metaminux
Copy link
Author

Hi @sbejaoui

Can we work on this PR and avoid related issues being auto closed ?

@diniciacci gave feedback on related issues...

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 17, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@metaminux
Copy link
Author

This PR should be replaced by #201

I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
2 participants