-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] brand_external_report_layout : keep original company for report… #180
Conversation
Hi @sbejaoui, |
Hi @sbejaoui and others, In this PR, I had to make some arbitrary choices about the list of fields to override... Do not hesitate to review, give advice, discuss. Regards, |
Hello everyone, Before spending more time on test coverage, I'd like some thoughts about this implementation. I think avoiding conflicts with other modules and enabling multi-company is necessary for larger adoption, but I'm not sure about updating company with brand data during report rendering and choices made about fields to really consider... Anyone ? @sbejaoui ? @pierre-halleux ? @jdoutreloux ? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi @sbejaoui Can we work on this PR and avoid related issues being auto closed ? @diniciacci gave feedback on related issues... |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This PR should be replaced by #201 I'm closing it. |
…s and just temporarily use brand data
Fixes #167
Fixes #179