[16.0][IMP] choose between brand or company values in layout #201
Conversation
|
Hi @sbejaoui, |
| "primary_color", | ||
| "secondary_color", | ||
| "layout_background", | ||
| "layout_background_image", |
There was a problem hiding this comment.
Actually some fields are still not overridden.
'report_header'
'company_details'
'report_layout_id'
To elaborate.
The error is gone. A report is generated. But it is rather a mixture of the report set on the company level and the brand level.
The colors are a mixture of both settings.
The tag line/header is not filled with the "brand" one.
Background image not working.
The adress still show the company adress. Instead of the adress of the Brand.
There was a problem hiding this comment.
Oopsie part of this bug is actually fixed in #195
There was a problem hiding this comment.
Hi @bosd
Can you mark this as resolved to allow merging again ?
@OCA/brand-maintainers Can someone approve this PR ? Please...
There was a problem hiding this comment.
Hi @bosd
Can you mark this as resolved to allow merging again ?
@OCA/brand-maintainers Can someone approve this PR ? Please...
Yeah, I could do that. But it is actually not resolved. So maybe better fix the functionality before merging.
Inspired of #180 and could replace it.
Here a way to select and use brand fields on reports and avoid the missing field error if a module add a new field on res.company