Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] brand_external_report_layout #205

Open
wants to merge 42 commits into
base: 17.0
Choose a base branch
from

Conversation

antonioburic
Copy link
Member

No description provided.

sbejaoui and others added 30 commits July 7, 2024 21:50
Co-Authored-By: Stéphane Bidoul (ACSONE) <[email protected]>
Currently translated at 96.0% (48 of 50 strings)

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: brand-16.0/brand-16.0-brand_external_report_layout
Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-brand_external_report_layout/
@antonioburic antonioburic mentioned this pull request Jul 7, 2024
11 tasks
@CasVissers-360ERP
Copy link

@antonioburic can you include #195

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

antonioburic and others added 2 commits October 1, 2024 09:00
The field works like on res.company model

[FIX] add missing import

[IMP] formatting
@antonioburic antonioburic force-pushed the 17.0-mig-brand_external_report_layout branch from a4d0a03 to c9eda59 Compare October 1, 2024 07:01
1. Go to Settings \> Users & Companies \> Brands
2. Add a new brand or select an existing one
3. Enter brand information and select the a layout
4. Go to any branded object abd print the PDF report. It includes the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Go to any branded object abd print the PDF report. It includes the
4. Go to any branded object and print the PDF report. It includes the

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this.
During functional test, I was unable to produce a branded pdf.

Steps to reproduce on runboat

  1. Go to Settings > Users & Companies > Brands
  2. Add a new brand
  3. Upload a logo, enter some info click change document template..
  4. Change some color.
  5. See the changed document on the form..
  6. Click Download PDF Preview
  7. Open the downloaded pdf. The changes made to the standard document are not visible.

@bosd
Copy link

bosd commented Nov 7, 2024

Please include #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.