[MIG] product_brand: Migration to 18.0 #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
approved these changes
Sep 18, 2024
marielejeune
suggested changes
Sep 19, 2024
marielejeune
suggested changes
Sep 19, 2024
samirGuesmi
force-pushed
the
18.0-mig-product_brand
branch
from
30a665d to
034ec80
Compare
| select_str += """ | ||
| , template.product_brand_id as product_brand_id | ||
| """ | ||
| return select_str |
There was a problem hiding this comment.
Shouldn't you do the same correction in the following _group_by method?
samirGuesmi
force-pushed
the
18.0-mig-product_brand
branch
from
034ec80 to
0ee8e61
Compare
| @@ -65,15 +65,15 @@ | |||
| </form> | |||
| </field> | |||
| </record> | |||
| <record id="view_product_brand_tree" model="ir.ui.view"> | |||
| <field name="name">product.brand.tree</field> | |||
| <record id="view_product_brand_list" model="ir.ui.view"> | |||
There was a problem hiding this comment.
It is usually a bad idea to rename views XMLids and names, it may cause a lot of side effects.
As far as I know, Odoo has kept all "tree" refs in their view namings.
I think we should do the same.
samirGuesmi
force-pushed
the
18.0-mig-product_brand
branch
from
0ee8e61 to
56cd277
Compare
… Thanks to NetAndCo who starts the module
* add smart button, move menu to a more visible position. * show brand in product.template kanban and tree views. * show brand in product variant kanban and tree views. * add product_brand kanban view. * update module's README and manifest file. * Search and group by brand for both product.product and product.template. * Convert model to new APIs. * Refactor products_count computation using product_ids one2many field. * Add public read access to product.brand (fixes 403 error on webshop for public user). * Make brand name required.
Migration to 10.0
Old form view was out of order: form blocks misaligned, because it was not using Odoo 10 views styling and layout.
Lookup fails when the ID is formatted. The unformatted version of the data is located under `raw_value`.
Currently translated at 100,0% (21 of 21 strings) Translation: product-attribute-11.0/product-attribute-11.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/product-attribute-11-0/product-attribute-11-0-product_brand/de/
… with other odoo apps. (#364) * Make the logo always the same width (64px). * Remove the description (200 first caracters). Not relevant for a configuration model. * Move the brand name and product count beside the image. This is the way it is displayed in partners and products kanban views.
…installed This solves the issue OCA#141
Currently translated at 78.2% (18 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/it/
Currently translated at 30.4% (7 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/sl/
Currently translated at 78.2% (18 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/it/
Currently translated at 78.2% (18 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/it/
Currently translated at 100.0% (23 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/es_AR/
Currently translated at 100.0% (23 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/es/
Currently translated at 100.0% (23 of 23 strings) Translation: brand-16.0/brand-16.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-16-0/brand-16-0-product_brand/pt/
- Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: brand-17.0/brand-17.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-product_brand/
Currently translated at 100.0% (22 of 22 strings) Translation: brand-17.0/brand-17.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-product_brand/it/
Currently translated at 100.0% (22 of 22 strings) Translation: brand-17.0/brand-17.0-product_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-product_brand/pt_BR/
* Rule product.brand.public has no group, this is a deprecated feature. odoo/odoo#125216 * Every access-granting rule should specify a group. odoo/odoo@ce1a4a2
samirGuesmi
force-pushed
the
18.0-mig-product_brand
branch
from
56cd277 to
9faeea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR : Migration to 18.0