[FIX] sale_commission_product_criteria_domain: consider credit note

OCA · Jul 1, 2024 · 10dea70 · 10dea70
1 parent 0bd3668
commit 10dea70
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/sale_commission_product_criteria/models/account_move.py b/sale_commission_product_criteria/models/account_move.py
@@ -25,7 +25,7 @@ def _compute_amount(self):
                     inv_line.product_id,
                     inv_line.quantity,
                 )
-                if line.invoice_id.move_type == 'out_refund':
+                if line.invoice_id.move_type == "out_refund":
                     line.amount = -amount
                 else:
                     line.amount = amount

diff --git a/sale_commission_product_criteria_domain/models/account_invoice_line_agent.py b/sale_commission_product_criteria_domain/models/account_invoice_line_agent.py
@@ -19,12 +19,16 @@ def _compute_amount(self):
                 and line.commission_id.commission_type == "product_restricted"
             ):
                 inv_line = line.object_id
-                line.amount = line._get_single_commission_amount(
+                amount = line._get_single_commission_amount(
                     line.commission_id,
                     inv_line.price_subtotal,
                     inv_line.product_id,
                     inv_line.quantity,
                 )
+                if line.invoice_id.move_type == "out_refund":
+                    line.amount = -amount
+                else:
+                    line.amount = amount
             else:
                 res = super(AccountInvoiceLineAgent, line)._compute_amount()
         return res