Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_commission_salesman: Migration to version 15.0 #402

Merged
merged 17 commits into from
Feb 24, 2023

Conversation

ernesto-garcia-tecnativa
Copy link
Contributor

@Tecnativa TT37305

pedrobaeza and others added 16 commits February 23, 2023 17:24
This module extends the functionality of `sale_commission` to allow you to
auto-populate salesmen as commission agents without setting explicitly them
on the customer.

**IMPORTANT**: The salesman will be only populated if no other commission agent
is set via other method, to assure that there's no overlapping commissions.

Configuration
=============

* Go to *Contacts*.
* Search for the contact linked to the salesman user and open it.
* If it's actually linked to a user, you'll see a new check in the
  *Agent information* page, called "Convert salesman into agent".
* Check it for having that salesman automatically populated as agent. You
  need to assign a commission to that agent as well.

Usage
=====

To use this module, you need to:

* Go to *Sales > Orders > Quotations* and create a new one.
* Fill the customer with one with no agents set.
* Select a salesman with the mark checked.
* Add a line in the quotation, and you will see the salesman populated as
  commission agent.
* Standard procedure
* Adapt account.invoice > account.move
* Adapt tests
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es_AR/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es_AR/
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/es/
Solves [13.0] sale_commission_pricelist - sale_commission_salesman error OCA#274
Currently translated at 100.0% (6 of 6 strings)

Translation: commission-13.0/commission-13.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_salesman/ca/
Currently translated at 11.1% (1 of 9 strings)

Translation: commission-14.0/commission-14.0-sale_commission_salesman
Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_salesman/it/
@ernesto-garcia-tecnativa ernesto-garcia-tecnativa force-pushed the 15.0-mig-sale_commission_salesman branch 2 times, most recently from 86427f8 to 7a7aa46 Compare February 23, 2023 23:54
@ernesto-garcia-tecnativa ernesto-garcia-tecnativa force-pushed the 15.0-mig-sale_commission_salesman branch from 7a7aa46 to 06d3240 Compare February 24, 2023 00:00
@ernesto-garcia-tecnativa
Copy link
Contributor Author

@pedrobaeza please review

@pedrobaeza
Copy link
Member

/ocabot migration sale_commission_salesman

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 24, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 24, 2023
5 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#328) has been updated to reference the current pull request.
however, a previous pull request was referenced : #401.
Perhaps you should check that there is no duplicate work.
CC : @ernesto-garcia-tecnativa

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now the name is correct:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-402-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 525d738 into OCA:15.0 Feb 24, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b36f378. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants