Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] commission: Add new settlement period (All pending records) to settle in only one settlement #530

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][IMP] commission: Add new settlement period (All pending records) to settle in only one settlement #530

wants to merge 1 commit into from
+228 −8

Conversation

sergio-teruel
Copy link
Contributor

Missing commit 1051782 from 15.0

cc @Tecnativa

ping @victoralmau @CarlosRoca13

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 17.0 milestone May 20, 2024
pedrobaeza
pedrobaeza reviewed May 20, 2024
View reviewed changes
account_commission/tests/test_account_commission.py Outdated
.create(
{
"reason": "no reason",
"refund_method": "refund",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this

account_commission/tests/test_account_commission.py Outdated
.create(
{
"reason": "no reason",
"refund_method": "cancel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

account_commission/tests/test_account_commission.py Outdated
.create(
{
"reason": "no reason",
"refund_method": "modify",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@pedrobaeza
Copy link
Member

@sergio-teruel please fix the fw-port for merging it.

@sergio-teruel sergio-teruel force-pushed the 17.0-IMP-commission-missing-commits branch from de791df to 44b10b5 Compare September 26, 2024 09:03
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 26, 2024
@pedrobaeza
Copy link
Member

Not enough yet

@sergio-teruel
Copy link
Contributor Author

the repo is weird

@pedrobaeza
Copy link
Member

Well, the error seems clear that has to do with how to do a refund:

2024-09-26 09:06:27,009 244 INFO odoo odoo.addons.sale_commission.tests.test_sale_commission: Starting TestSaleCommission.test_invoice_full_refund ... 
2024-09-26 09:06:27,342 244 INFO odoo odoo.addons.sale_commission.tests.test_sale_commission: ====================================================================== 
2024-09-26 09:06:27,342 244 ERROR odoo odoo.addons.sale_commission.tests.test_sale_commission: FAIL: TestSaleCommission.test_invoice_full_refund
Traceback (most recent call last):
  File "/__w/commission/commission/account_commission/tests/test_account_commission.py", line 610, in test_invoice_full_refund
    self.assertEqual(2, len(settlements.line_ids))
AssertionError: 2 != 0

@sergio-teruel
Copy link
Contributor Author

Thera is a lot of commits from v16 missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sergio-teruel @OCA-git-bot @pedrobaeza