Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] sale_commission_product_criteria_domain: onchange partner agents #580

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

aleuffre
Copy link

Fixes an issue with the recomputation of commission item agent lines. Existing lines were not always recognized as such, due to NewIds, and so were recomputed when they shouldn't have been.

@OCA-git-bot
Copy link
Contributor

Hi @renda-dev, @PicchiSeba, @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

Copy link

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@PicchiSeba
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-580-by-PicchiSeba-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d1f81a5 into OCA:14.0 Nov 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 51d6489. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-scpcd-onchange-agent branch November 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants