[FIX] dms: fix directory files action

If the directory is empty, the action would return all files,
and the panel show all directories except for the one that triggered the action.

The file count was not consistent with the action if the directory is
hidden, since its files would thus also be hidden; this field is a
related on the storage, so the value is consistent for the directory and
all its files.

dms/models/directory.py

@@ -446,12 +446,33 @@ def _compute_count_total_directories(self):
             )
             record.count_total_directories = count - 1 if count > 0 else 0
 
+    def _get_directory_files_domain(self):
+        self.ensure_one()
+        return [
+            ("directory_id", "child_of", self.id),
+            ("is_hidden", "=", self.is_hidden),
+        ]
+
+    def action_dms_files_all_directory(self):
+        self.ensure_one()
+        return {
+            "type": "ir.actions.act_window",
+            "name": _("Files"),
+            "res_model": "dms.file",
+            "view_mode": "tree,form",
+            "domain": self._get_directory_files_domain(),
+            "context": {
+                "default_directory_id": self.id,
+                "searchpanel_default_directory_id": self.id,
+            },
+        }
+
     def _compute_count_total_files(self):
         model = self.env["dms.file"]
         for record in self:
             # Prevent error in some NewId cases
             record.count_total_files = (
-                model.search_count([("directory_id", "child_of", record.id)])
+                model.search_count(record._get_directory_files_domain())
                 if record.id
                 else 0
             )

dms/views/directory.xml

@@ -82,30 +82,6 @@
             </p>
         </field>
     </record>
-    <record id="action_dms_files_all_directory" model="ir.actions.act_window">
-        <field name="name">Files</field>
-        <field name="res_model">dms.file</field>
-        <field name="view_mode">kanban,tree,graph,pivot,form</field>
-        <field name="domain">
-            [
-            ("is_hidden", "=", False),
-            ]
-        </field>
-        <field name="context">
-            {
-            'default_directory_id': active_id,
-            'searchpanel_default_directory_id': active_id
-            }
-        </field>
-        <field name="help" type="html">
-            <p class="o_view_nocontent_smiling_face">
-                Click to add a new file.
-            </p>
-            <p>
-                Files are used to save content directly in Odoo.
-            </p>
-        </field>
-    </record>
     <record id="search_dms_directory" model="ir.ui.view">
         <field name="name">dms_directory.search</field>
         <field name="model">dms.directory</field>
@@ -240,8 +216,8 @@
                                                 Directories
                                             </a>
                                             <a
-                                                type="action"
-                                                name="%(dms.action_dms_files_all_directory)d"
+                                                type="object"
+                                                name="action_dms_files_all_directory"
                                                 role="menuitem"
                                                 class="dropdown-item"
                                             >
@@ -415,8 +391,8 @@
                             />
                         </button>
                         <button
-                            type="action"
-                            name="%(dms.action_dms_files_all_directory)d"
+                            type="object"
+                            name="action_dms_files_all_directory"
                             class="oe_stat_button"
                             icon="fa-file-text-o"
                         >