[17.0][MIG] website_sale_product_minimal_price: Migration to version 17.0 #1007
+1,482
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration website_sale_product_minimal_price |
|
The changes make sense, but IDK how will they impact on the e-commerce performance... ping @sergio-teruel |
|
/ocabot migration website_sale_product_minimal_price |
* [11.0][NEW] website_sale_product_minimal_price: New module * [11.0][IMP] website_sale_product_minimal_price: Order by minimal variant price (from pricelists or extra variant price) [UPD] Update website_sale_product_minimal_price.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_minimal_price/ [UPD] README.rst
… avoid the inheritance problems
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/es/
Ensure we use a consistant currency TT28906
…s of 12.0 Forward port adapting the minimal price computing to the new way added on version 13.0. With the changes added the price takes care on the website selected pricelist and it's added the grid of price scale for each product.variant. TT24175
…list item When the product has a sales price = 0, his variants has no extra price and a pricelist depends on other pricelists to compute the prices, the algorithm takes a random variant. Doing this changes we take care all pricelists that depends on the main to compute the prices asociated to the product. This changes are forward ported and addapted to 13.0 version from this commit OCA@fe99a35#diff-d3f954ac4904966e21fd42f7b88212a43b229ad5c025afc848408a4127215ebe
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-website_sale_product_minimal_price
branch
2 times, most recently
from
99ebec0 to
bb3bf83
Compare
pilarvargas-tecnativa
approved these changes
Mar 5, 2025
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-website_sale_product_minimal_price
branch
from
bb3bf83 to
8b06bc7
Compare
sergio-teruel
suggested changes
Mar 9, 2025
There was a problem hiding this comment.
Hi @carlos-lopez-tecnativa
The main view of all productos is OK, the price is the minal of all combinations
But the minimal combination shown in product form view is no the minal combination
Can you review??
Thanks...
|
@sergio-teruel I tried to reproduce this case in V16, and it works the same way. Could you please provide more details about the product configuration, pricelist, and extra prices for attributes? According to this code, it only sorts by price_extra, not by pricelist.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"From"label instead of handling it in JS to avoid flickering./website_sale/get_combination_info. The data is now obtained in_onChangeCombination, eliminating the need for a new request to the server. The unused controller has been removed._read_groupinstead of search + filter.TT52394
@Tecnativa @pedrobaeza @CarlosRoca13 @chienandalu @pilarvargas-tecnativa @sergio-teruel Could you please review this? Thanks!