Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] edi_oca #115

Merged
merged 377 commits into from
Jan 14, 2025
Merged

[18.0][MIG] edi_oca #115

merged 377 commits into from
Jan 14, 2025

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Oct 23, 2024 •
edited
Loading

depends on:

includes all FW in #125

@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_oca branch 2 times, most recently from 367c091 to fda5acb Compare October 23, 2024 15:02
@JordiMForgeFlow JordiMForgeFlow mentioned this pull request Oct 23, 2024
Merged
@JordiMForgeFlow JordiMForgeFlow mentioned this pull request Oct 24, 2024
Open
2 tasks
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_oca branch 4 times, most recently from b7d3952 to e9b81ef Compare October 25, 2024 14:00
@JordiMForgeFlow JordiMForgeFlow marked this pull request as ready for review October 25, 2024 14:00
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_oca branch 4 times, most recently from 391f6ca to 6a1c9a2 Compare October 28, 2024 07:28
@JordiMForgeFlow
Copy link
Contributor Author

@simahawk @etobella

The CI fails due to the warning logged in

edi-framework/edi_oca/models/edi_exchange_record.py

Line 490 in 03961fb

_logger.warning(

There is one test that is also ensuring that the warning is logged.

How would you deal with this one? Maybe use an info log when running the tests?

@JordiMForgeFlow
Copy link
Contributor Author

@etobella @simahawk ready for review :)

@JordiMForgeFlow JordiMForgeFlow mentioned this pull request Nov 21, 2024
Closed
@MiquelRForgeFlow
Copy link
Contributor

I think you should consider as base #125 instead of #118, and then include any missing FW commit.

oca-ci and others added 10 commits December 27, 2024 15:55
@JordiMForgeFlow
[UPD] Update edi_oca.pot
f6c9a2e
@OCA-git-bot @JordiMForgeFlow
[BOT] post-merge updates
ecafeef
@weblate @JordiMForgeFlow
Update translation files
edf828a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-framework-17.0/edi-framework-17.0-edi_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-framework-17-0/edi-framework-17-0-edi_oca/
@mymage @JordiMForgeFlow
Translated using Weblate (Italian)
941a73e 
Currently translated at 100.0% (226 of 226 strings)

Translation: edi-framework-17.0/edi-framework-17.0-edi_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-framework-17-0/edi-framework-17-0-edi_oca/it/
@JordiMForgeFlow
[UPD] Update edi_oca.pot
af33eae
@weblate @JordiMForgeFlow
Update translation files
ae82587 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-framework-17.0/edi-framework-17.0-edi_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-framework-17-0/edi-framework-17-0-edi_oca/
@mymage @JordiMForgeFlow
Translated using Weblate (Italian)
3dc7b51 
Currently translated at 100.0% (227 of 227 strings)

Translation: edi-framework-17.0/edi-framework-17.0-edi_oca
Translate-URL: https://translation.odoo-community.org/projects/edi-framework-17-0/edi-framework-17-0-edi_oca/it/
@JordiMForgeFlow
[IMP] edi_oca: pre-commit stuff
c0bf969
@JordiMForgeFlow
[MIG] edi_oca: Migration to V18
7bb84f6
@JordiMForgeFlow
[ADD] test-requirements
bbce5f7
@JordiMForgeFlow JordiMForgeFlow force-pushed the 18.0-mig-edi_oca branch 2 times, most recently from ad4c059 to bbce5f7 Compare December 30, 2024 10:57
@JordiMForgeFlow
Copy link
Contributor Author

@MiquelRForgeFlow done!

thienvh332
thienvh332 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@thienvh332 thienvh332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall,

Small changes:

edi_oca/views/edi_exchange_record_views.xml Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiMForgeFlow
Copy link
Contributor Author

@etobella ready to merge :)

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-115-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4a73f4f into OCA:18.0 Jan 14, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0172c40. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 18.0-mig-edi_oca branch January 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thienvh332 thienvh332 thienvh332 approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.