[17.0][ADD] edi_project_oca: New module #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvioC2C
changed the title
SilvioC2C
force-pushed
the
17.0-add-edi_project_oca
branch
from
c557d6a to
ebf2b12
Compare
gurneyalex
approved these changes
Dec 6, 2024
simahawk
requested changes
Dec 6, 2024
SilvioC2C
force-pushed
the
17.0-add-edi_project_oca
branch
from
ebf2b12 to
2384694
Compare
SilvioC2C
force-pushed
the
17.0-add-edi_project_oca
branch
2 times, most recently
from
ce7193a to
4ecae03
Compare
simahawk
reviewed
Dec 6, 2024
SilvioC2C
force-pushed
the
17.0-add-edi_project_oca
branch
from
4ecae03 to
6d7b9f5
Compare
simahawk
requested changes
Dec 6, 2024
edi_project_oca/tests/common.py
Outdated
| component_cls._build_component(cls.comp_registry) | ||
| cls.comp_registry._cache.clear() | ||
|
|
||
| def _check_msg_in_log_output(self, msg: str, outputs: Iterable): |
There was a problem hiding this comment.
kind of complicating things? 😄
See here how you can collect dummy events https://github.com/OCA/edi/blob/14.0/edi_oca/tests/fake_components.py#L10
Yet... se below...
| _logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class TestProjectListener(TestEdiProjectOcaCommon): |
There was a problem hiding this comment.
you don't need all this testing... these are std events provided by component_event. You can simply drop them 😉
SilvioC2C
force-pushed
the
17.0-add-edi_project_oca
branch
from
6d7b9f5 to
97d7c3e
Compare
simahawk
approved these changes
Dec 11, 2024
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 75d6e84. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.