[18.0][ADD] edi_exchange_template_oca_json #136
Closed
+626
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlopes
force-pushed
the
18.0-add-edi_exchange_template_json
branch
from
3605825 to
7208826
Compare
imlopes
force-pushed
the
18.0-add-edi_exchange_template_json
branch
2 times, most recently
from
611b2c8 to
cc00018
Compare
imlopes
force-pushed
the
18.0-add-edi_exchange_template_json
branch
from
cc00018 to
df9e01a
Compare
simahawk
requested changes
Jan 24, 2025
| result = self._post_process_json_output(result) | ||
| return result | ||
|
|
||
| def _render_json_values(self, exchange_record, **kw): |
There was a problem hiding this comment.
this module shouldn't rely on jsonifier.
You should be able to generate JSOn as you prefer.
The snippet can simply be something like
exporter = env.ref(...)
parser = exporter.get_json_parser()
result = record.jsonifier(parser, [one=True])
The role of this module is only to handle and validate the JSON result.
|
Additionally, please, drop the odoo version from the commit. Thanks :) |
|
Hello, Italo, as I wasn't able to push on you're branch during your timeoff, I created this PR instead: #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.