Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_invoice_factux: stop pinning factur-x lib #1140

Conversation

alexis-via
Copy link
Contributor

No description provided.

@alexis-via alexis-via force-pushed the 16-account_invoice_facturx-stop_pinning_facturx_lib branch from ec958a8 to 4215c81 Compare April 2, 2025 22:43
@alexis-via
Copy link
Contributor Author

@simahawk I don't know the root cause for #1089 but now tests are green without pinning an old version of the factur-x lib, so I created this PR to remove the pinning in v16.
I guess the pinning must be kept in v14 because the tests in v14 use python 3.6.
Pinning could be removed in v15 because the tests in v15 use python 3.8.

@alexis-via
Copy link
Contributor Author

FYI, pinning is not present in v17 and v18, so no need to forward port.

@alexis-via
Copy link
Contributor Author

/ocabot merge minor

1 similar comment
@alexis-via
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1140-by-alexis-via-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 182c2f9 into OCA:16.0 Apr 7, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4040e65. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants