[IMP] fieldservice_portal: order visibility by stage #1319

brian10048 · 2025-02-05T20:22:48Z

Adds a field on fsm_stage that allows to enable or disable visibility of fsm orders in the portal
Adds a method _prepare_fsm_orders_domain() that returns a domain for searching fsm orders able to be shown on the portal. This could be overridden for other needs

OCA-git-bot · 2025-02-05T20:22:53Z

Hi @renda-dev, @aleuffre,
some modules you are maintaining are being modified, check this out!

anusriNPS

Code review, LGTM.

A minor comment which helps readability.

anusriNPS · 2025-02-06T08:30:00Z

fieldservice_portal/models/fsm_stage.py

+    portal_visible = fields.Boolean(
+        string="Visible in Portal",
+        default=True,
+        help="Enable to display field service orders of this stage in the portal",


Typo: Enable to display field service orders based on it's stage in the portal

aleuffre

Code review, LGTM. Thank you

aleuffre · 2025-02-10T09:30:47Z

/ocabot merge minor

OCA-git-bot · 2025-02-10T09:30:58Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1319-by-aleuffre-bump-minor, awaiting test results.

Signed-off-by aleuffre

OCA-git-bot · 2025-02-10T09:39:33Z

@aleuffre The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name field-service --branch 15.0 --addons-dir /tmp/tmpm450r7sg --commit failed with output:

/tmp/tmpm450r7sg/fieldservice_portal/README.rst:65: (SEVERE/4) Title level inconsistent:

Authors
~~~~~~~
Traceback (most recent call last):
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 347, in check_subsection
    level = title_styles.index(style) + 1
            ^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: '~' is not in list

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 8, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 3034, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2790, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2790, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 324, in section
    if self.check_subsection(source, style, lineno):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 353, in check_subsection
    self.parent += self.title_inconsistent(source, lineno)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 369, in title_inconsistent
    error = self.reporter.severe(
            ^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 239, in severe
    return self.system_message(self.SEVERE_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpm450r7sg/fieldservice_portal/README.rst:65: (SEVERE/4) Title level inconsistent:

Authors
~~~~~~~

aleuffre · 2025-02-10T09:57:33Z

@brian10048 could you try regenerating the README locally? Thanks

brian10048 · 2025-02-10T14:56:00Z

/ocabot merge minor

OCA-git-bot · 2025-02-10T14:56:09Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1319-by-brian10048-bump-minor, awaiting test results.

OCA-git-bot · 2025-02-10T15:04:51Z

Congratulations, your PR was merged at 5d9f615. Thanks a lot for contributing to OCA. ❤️

brian10048 requested review from anusriNPS, renda-dev and aleuffre February 5, 2025 20:22

brian10048 force-pushed the dev-15-portal-imp branch 3 times, most recently from f8134a4 to 505154f Compare February 5, 2025 20:46

anusriNPS approved these changes Feb 6, 2025

View reviewed changes

brian10048 force-pushed the dev-15-portal-imp branch from 505154f to ef7832c Compare February 7, 2025 15:55

aleuffre approved these changes Feb 10, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 10, 2025

OCA-git-bot added a commit that referenced this pull request Feb 10, 2025

Merge PR #1319 into 15.0

aae0437

Signed-off-by aleuffre

OCA-git-bot added the bot is merging ⏳ label Feb 10, 2025

OCA-git-bot removed the bot is merging ⏳ label Feb 10, 2025

[IMP] fieldservice_portal: order visibility by stage

820ae83

brian10048 force-pushed the dev-15-portal-imp branch from ef7832c to 820ae83 Compare February 10, 2025 14:47

OCA-git-bot added the bot is merging ⏳ label Feb 10, 2025

OCA-git-bot merged commit 8b6b1cb into OCA:15.0 Feb 10, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 10, 2025

This was referenced Feb 10, 2025

[16.0] [IMP] fieldservice_portal: order visibility by stage #1320

Merged

[17.0] [IMP] fieldservice_portal: order visibility by stage #1321

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] fieldservice_portal: order visibility by stage #1319

[IMP] fieldservice_portal: order visibility by stage #1319

brian10048 commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

anusriNPS left a comment

anusriNPS Feb 6, 2025

aleuffre left a comment

aleuffre commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

aleuffre commented Feb 10, 2025

brian10048 commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

[IMP] fieldservice_portal: order visibility by stage #1319

[IMP] fieldservice_portal: order visibility by stage #1319

Conversation

brian10048 commented Feb 5, 2025

OCA-git-bot commented Feb 5, 2025

anusriNPS left a comment

Choose a reason for hiding this comment

anusriNPS Feb 6, 2025

Choose a reason for hiding this comment

aleuffre left a comment

Choose a reason for hiding this comment

aleuffre commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

aleuffre commented Feb 10, 2025

brian10048 commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025