Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [16.0] hr_expense_invoice: Decide when to check expense amount #268

Conversation

Shide
Copy link

@Shide Shide commented Sep 13, 2024

Check only the expense amount when some kind of amount (subtotal or taxes) are being changed on the invoice

MT-5202 @moduon @rafaelbn @loida-vm @pedrobaeza please review if you want.

@Shide Shide force-pushed the 16.0-decide_when_to_check_expense-hr_expense_invoice branch from b4cc7ac to 45b5c23 Compare September 13, 2024 08:47
@Shide
Copy link
Author

Shide commented Sep 13, 2024

Fixes this issue: #249 (review)

@Shide Shide marked this pull request as draft September 13, 2024 08:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Shide Shide force-pushed the 16.0-decide_when_to_check_expense-hr_expense_invoice branch from 45b5c23 to bdb7d76 Compare September 13, 2024 08:57
@Shide Shide marked this pull request as ready for review September 13, 2024 08:58
Copy link

@loida-vm loida-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case 2, mentioned here, tested functionally and it works. LGTM!

Thank you @Shide

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 13, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-268-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 77f9ea7 into OCA:16.0 Sep 13, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37ca944. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-decide_when_to_check_expense-hr_expense_invoice branch September 13, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants