[16.0][FIX] hr_expense_*: Fix + improve tests #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
changed the title
victoralmau
changed the title
|
Finally, it is ready for review. |
pedrobaeza
approved these changes
Nov 27, 2024
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 1a12f3d. Thanks a lot for contributing to OCA. ❤️ |
|
I will add these changes also to v17 now. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done:
hr_expense_cancel: Fix + improve testshr_expense_payment: Fix + improve testshr_expense_advance_clearing: Fix + improve testshr_expense_tier_validation: Fix + improve testshr_expense_invoice: Fix + improve testsRelated to odoo/odoo@063e224
Related to #276 (comment)
Please @pedrobaeza can you review it?
@Tecnativa