Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] document_page: Change web_ribbon text to title to make it translatable #455

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

victoralmau
Copy link
Member

Change web_ribbon text to title to make it translatable

@Tecnativa

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 29, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing about the translations

@victoralmau victoralmau force-pushed the 15.0-fix-document_page-web_ribbon branch from be96e88 to bea482d Compare January 30, 2024 07:17
@victoralmau
Copy link
Member Author

Changes done.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-455-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c7be4a0 into OCA:15.0 Jan 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-455-by-pedrobaeza-bump-minor:15.0 failed with output:

To https://github.com/OCA/knowledge
 ! [rejected]          15.0-ocabot-merge-pr-455-by-pedrobaeza-bump-minor -> 15.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/knowledge'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at efbadc5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants