[16.0][NEW] l10n_br_crm_cnpj_search: busca de CNPJ através do Lead #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corredato
changed the title
rvalyi
previously requested changes
Aug 22, 2024
There was a problem hiding this comment.
@corredato, tem que ver os testes e inclusive adicionar testes com um mock semelhante ao que foi feito no módulo de busca. No repo precisa de 90% de test coverage. Até bater ter isso é bom botar o PR como rascunho.
mileo
requested changes
Aug 26, 2024
|
Depends on #3306 |
corredato
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
6a999df
to
ad35598
Compare
corredato
force-pushed
the
feature/cnpj-search-crm-lead
branch
3 times, most recently
from
191eae9
to
b919379
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
acc4fda
to
87363be
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
11 times, most recently
from
f1e386b
to
90139da
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
3 times, most recently
from
c173033
to
aa72314
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
6 times, most recently
from
ee35986
to
5f9975f
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
5f9975f
to
4188871
Compare
mileo
approved these changes
Oct 25, 2024
rvalyi
approved these changes
Oct 25, 2024
kaynnan
approved these changes
Oct 25, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3926b5e. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combinação do l10n_br_cnpj_search e l10n_br_crm havia uma ponta solta: Caso necessário, não era possível realizar uma busca das informações de uma empresa através do CNPJ em um lead que não tinha partner_id preenchido, esse módulo faz com que esse problema não exista mais, além de fazer com que informações como CNAE primário, CNAE secundário, capital e natureza legal sejam passadas para o cadastro do parceiro quando um novo contato é criado a partir da conversão de Lead para Oportunidade.
@mileo @antoniospneto @rvalyi