Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] l10n_br_fiscal: icms fcp and difal destination comments #3374

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[14.0] l10n_br_fiscal: icms fcp and difal destination comments #3374

merged 1 commit into from
Sep 20, 2024

Conversation

corredato
Copy link
Contributor

Novos comentários com o valor total do ICMS FCP e DIFAL Destino

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@corredato corredato force-pushed the feature/icms-fcp-difal-comment branch from b61ffc9 to a2cebc4 Compare September 19, 2024 22:00
@antoniospneto
Copy link
Contributor

antoniospneto commented Sep 19, 2024 •
edited
Loading

@corredato

Essa alteração é uma melhoria, então ali na mensagem do commit o prefixo correto seria [IMP]
o prefixo [ADD] é somente na criação de um módulo novo.

Veja: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

antoniospneto
antoniospneto reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@antoniospneto antoniospneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho bem vindo, só verificar ali a questão da mensagem do commit.

Edit: verificar também os testes.

@antoniospneto antoniospneto changed the title [14.0][ADD] l10n_br_fiscal: icms fcp and difal destiny comments [14.0] l10n_br_fiscal: icms fcp and difal destiny comments Sep 19, 2024
@corredato corredato force-pushed the feature/icms-fcp-difal-comment branch from a2cebc4 to 02e4be5 Compare September 19, 2024 23:36
@corredato
Copy link
Contributor Author

corredato commented Sep 19, 2024 •
edited
Loading

@corredato

Essa alteração é uma melhoria, então ali na mensagem do commit o prefixo correto seria [IMP] o prefixo [ADD] é somente na criação de um módulo novo.

Veja: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

@antoniospneto Corrigida a mensagem do commit, ainda não entendi o problema com os testes, assim que puder vou resolver.

Valeu pela revisão

antoniospneto
antoniospneto approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@antoniospneto antoniospneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agora os testes passaram, deve ter sido alguma incosistencia temporaria.
Obrigado @corredato

@rvalyi
Copy link
Member

rvalyi commented Sep 20, 2024

falando em mensagem de commit: a palavra certa é destination e não destiny.

@corredato
Copy link
Contributor Author

falando em mensagem de commit: a palavra certa é destination e não destiny.

Vou arrumar, valeu

@corredato corredato force-pushed the feature/icms-fcp-difal-comment branch from 02e4be5 to 3e5a4ea Compare September 20, 2024 01:09
@antoniospneto antoniospneto changed the title [14.0] l10n_br_fiscal: icms fcp and difal destiny comments [14.0] l10n_br_fiscal: icms fcp and difal destination comments Sep 20, 2024
@rvalyi
Copy link
Member

rvalyi commented Sep 20, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3374-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9dd2c62 into OCA:14.0 Sep 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 892f6f6. Thanks a lot for contributing to OCA. ❤️

This was referenced Sep 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corredato @OCA-git-bot @antoniospneto @rvalyi